From: Denys Dmytriyenko <denys@ti.com>
To: "Maupin, Chase" <chase.maupin@ti.com>
Cc: "meta-ti@yoctoproject.org" <meta-ti@yoctoproject.org>
Subject: Re: [PATCH] recipes-kernel: Add GLSDK specific kernel tree for omap-a15
Date: Thu, 27 Jun 2013 10:23:18 -0400 [thread overview]
Message-ID: <20130627142318.GK28379@edge> (raw)
In-Reply-To: <7D46E86EC0A8354091174257B2FED1015961B7AF@DLEE11.ent.ti.com>
> >+
> >+S = "${WORKDIR}/git"
> >+
> >+BRANCH = "master"
> >+
> >+# This commit corresponds to ti2013.04.02 release tag
>
> Sorry to nit-pick here, but any reason to re-use the tag name from the
> linux-ti-staging tree? The reason I ask is back to it being confusing if I
> have two trees with the same tag name (including version) it becomes kind of
> confusing. Especially since this tree is part of the same git.ti.com
> project as the other one. Thoughts?
Currently, it's just an identical copy of our LCPD tree w/o any patches on
top, so it has the same tags and commit IDs...
One can argue though, if the trees are still the same, what's the reason to
create a new recipe so early in advance?
> >+SRCREV = "f3cb62a800ae37f17a3382b10d155ee02dbc83fc"
> >+PV = "3.8.13"
> >+
> >+# Append to the MACHINE_KERNEL_PR so that a new SRCREV will cause
> >a rebuild
> >+MACHINE_KERNEL_PR_append = "f+gitr${SRCPV}"
>
> Go ahead and reset your append here to a+ gitr${SRCPV}. No need to start
> from f.
>
> Thanks for the submission. Overall looks pretty good, just a few things to
> fix up.
+1 keep up the good work!
--
Denys
next prev parent reply other threads:[~2013-06-27 14:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-27 10:13 [PATCH] recipes-kernel: Add GLSDK specific kernel tree for omap-a15 Siddharth Heroor
2013-06-27 12:14 ` Maupin, Chase
2013-06-27 13:34 ` Siddharth Heroor
2013-06-27 14:23 ` Denys Dmytriyenko [this message]
2013-06-27 14:31 ` Siddharth Heroor
2013-06-27 14:27 ` Siddharth Heroor
-- strict thread matches above, loose matches on Subject: below --
2013-06-27 13:49 Siddharth Heroor
2013-06-27 13:52 ` Cooper Jr., Franklin
2013-06-27 14:16 ` Maupin, Chase
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130627142318.GK28379@edge \
--to=denys@ti.com \
--cc=chase.maupin@ti.com \
--cc=meta-ti@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.