From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andy Whitcroft <apw@canonical.com>
Subject: Re: [PATCH 2/2] overlayfs -- follow change to do_splice_direct
 interface
Date: Thu, 27 Jun 2013 18:22:47 +0100
Message-ID: <20130627172247.GC5467@bark>
References: <1372350404-10359-1-git-send-email-apw@canonical.com>
 <1372350404-10359-4-git-send-email-apw@canonical.com>
 <CAJfpegsYPDi2oxt0WKHFrwYBjrk6-SNj_owghtOGxqyVVG45uQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Linux-Fsdevel <linux-fsdevel@vger.kernel.org>,
	Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"mszeredi@suse.cz" <mszeredi@suse.cz>,
	Al Viro <viro@zeniv.linux.org.uk>
To: Miklos Szeredi <miklos@szeredi.hu>
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <CAJfpegsYPDi2oxt0WKHFrwYBjrk6-SNj_owghtOGxqyVVG45uQ@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On Thu, Jun 27, 2013 at 06:37:45PM +0200, Miklos Szeredi wrote:
> Thanks for the patches, Andy.  I already pushed a similar set of fixes
> to overlayfs.current (.v18) and to .v17 for the dentry_open() refcount
> fix.

Bah so you did, that'll teach me for waiting for them to be tested.

> It is interesting how many people end up fixing this the wrong way ;)
> 
> Hint: how will the file offsets advance?

Interesting I got bluffed in by the original implementation which
reloaded the source pos each time.

-apw