From: Peter Zijlstra <peterz@infradead.org>
To: Stephane Eranian <eranian@google.com>
Cc: Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"mingo@elte.hu" <mingo@elte.hu>,
"ak@linux.intel.com" <ak@linux.intel.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung.kim@lge.com>
Subject: Re: [PATCH 0/8] perf: add ability to sample physical data addresses
Date: Fri, 28 Jun 2013 11:58:28 +0200 [thread overview]
Message-ID: <20130628095828.GG29209@dyad.programming.kicks-ass.net> (raw)
In-Reply-To: <CABPqkBTETCE7unsE=zvcC5n865ZN-QTW5Y0j-meTO9x-8=BJog@mail.gmail.com>
On Wed, Jun 26, 2013 at 09:10:50PM +0200, Stephane Eranian wrote:
> After more investigation with the author of the false sharing
> detection tool, I think
> that if the mapping changes, it is okay. The tool can detect this and
> drop the analysis
> at that address. So as long as we can flag the mapping change, we are
> okay. Hopefully,
> it does not occur frequently. If so, then I think there are bigger
> issues to fix on the system
> than false sharing.
But if you index everything using dev:inode:offset it doesn't matter if the
mapping changes; you're invariant to map placement.
And the thing is; we already compute most of that anyway in order to find the
code in DSOs, except there we use filename instead of dev:inode. However if
there were means to open files using dev:inode that might actually be more
reliable than using the filename.
next prev parent reply other threads:[~2013-06-28 9:59 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-21 14:20 [PATCH 0/8] perf: add ability to sample physical data addresses Stephane Eranian
2013-06-21 14:20 ` [PATCH 1/8] perf,x86: disable PEBS-LL in intel_pmu_pebs_disable() Stephane Eranian
2013-06-24 8:44 ` Peter Zijlstra
2013-06-26 7:35 ` Stephane Eranian
2013-06-27 9:01 ` [tip:perf/core] perf/x86: Disable " tip-bot for Stephane Eranian
2013-06-21 14:20 ` [PATCH 2/8] perf,x86: drop event->flags and use hw.constraint->flags Stephane Eranian
2013-06-24 8:45 ` Peter Zijlstra
2013-06-26 7:36 ` Stephane Eranian
2013-06-26 10:36 ` Peter Zijlstra
2013-06-27 10:23 ` Stephane Eranian
2013-06-27 10:48 ` Peter Zijlstra
2013-06-27 11:01 ` Stephane Eranian
2013-06-27 11:14 ` Peter Zijlstra
2013-06-27 12:33 ` Stephane Eranian
2013-06-27 14:10 ` Peter Zijlstra
2013-06-21 14:20 ` [PATCH 3/8] perf,x86: add uvirt_to_phys_nmi helper function Stephane Eranian
2013-06-21 14:20 ` [PATCH 4/8] perf: add PERF_SAMPLE_PHYS_ADDR sample type Stephane Eranian
2013-06-21 14:20 ` [PATCH 5/8] perf,x86: add support for PERF_SAMPLE_PHYS_ADDR for PEBS-LL Stephane Eranian
2013-06-21 14:20 ` [PATCH 6/8] perf tools: add infrastructure to handle PERF_SAMPLE_PHYS_ADDR Stephane Eranian
2013-06-21 14:20 ` [PATCH 7/8] perf record: add option to sample physical load/store addresses Stephane Eranian
2013-06-21 14:20 ` [PATCH 8/8] perf mem: add physical addr sampling support Stephane Eranian
2013-06-23 21:58 ` [PATCH 0/8] perf: add ability to sample physical data addresses Jiri Olsa
2013-06-24 8:16 ` Stephane Eranian
2013-06-24 8:45 ` Jiri Olsa
2013-06-24 8:43 ` Peter Zijlstra
2013-06-25 9:59 ` Stephane Eranian
2013-06-25 10:47 ` Peter Zijlstra
2013-06-25 10:51 ` Ingo Molnar
2013-06-26 10:33 ` Peter Zijlstra
2013-06-26 19:10 ` Stephane Eranian
2013-06-28 9:58 ` Peter Zijlstra [this message]
2013-07-05 22:48 ` Stephane Eranian
2013-07-08 8:19 ` Peter Zijlstra
2013-07-09 6:02 ` Stephane Eranian
2013-07-30 8:02 ` Stephane Eranian
2013-07-30 8:37 ` Peter Zijlstra
2013-07-30 8:51 ` Stephane Eranian
2013-07-30 9:02 ` Peter Zijlstra
2013-07-30 13:09 ` Stephane Eranian
2013-07-30 14:21 ` Stephane Eranian
2013-07-30 14:50 ` David Ahern
2013-07-30 14:53 ` Stephane Eranian
2013-07-30 14:59 ` David Ahern
2013-07-30 15:52 ` Peter Zijlstra
2013-07-30 16:09 ` Stephane Eranian
2013-07-30 16:16 ` Peter Zijlstra
2013-06-26 13:29 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130628095828.GG29209@dyad.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@redhat.com \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.