From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH] drm/i915: boost GPU and CPU freq when leaving idle Date: Fri, 28 Jun 2013 11:40:27 -0700 Message-ID: <20130628114027.041ed725@jbarnes-desktop> References: <1372438472-3233-1-git-send-email-jbarnes@virtuousgeek.org> <20130628183701.GF32183@cantiga.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from oproxy14-pub.unifiedlayer.com (oproxy14-pub.unifiedlayer.com [67.222.51.224]) by gabe.freedesktop.org (Postfix) with SMTP id DE738E66D8 for ; Fri, 28 Jun 2013 12:09:35 -0700 (PDT) In-Reply-To: <20130628183701.GF32183@cantiga.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: Owen Taylor , intel-gfx@lists.freedesktop.org, arjan@linux.intel.com List-Id: intel-gfx@lists.freedesktop.org On Fri, 28 Jun 2013 19:37:01 +0100 Chris Wilson wrote: > On Fri, Jun 28, 2013 at 09:54:32AM -0700, Jesse Barnes wrote: > > Coming out of idle is usually due to some sort of user input (swiping a > > screen, clicking a button) and often results in some sort of graphical > > animation. To prevent stutter for a CPU or GPU intensive animation, > > boost the GPU and CPU freq to the maximum to get the first frame out as > > quickly as possible. The normal CPU and GPU frequency management code > > will take over from there and (hopefully) clock down to save power as > > needed if the max frequencies aren't required. > > > > This could probably be done more cleanly, and possibly without another > > uncached read in the execbuf path if we tracked idleness elsewhere. I'm > > also unsure about the cpufreq calls; I don't really know if this will do > > what I want... > > Would seem like a good idea to make intel_mark_busy() dtrt and use them. That'll give us a slightly delayed idle indicator, but it should work ok... Owen, if this patch looks like it'll work for you, I'll update it to use our mark busy/idle stuff and see if we can merge it upstream. Thanks, -- Jesse Barnes, Intel Open Source Technology Center