From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Fri, 28 Jun 2013 16:21:14 +0200 (CEST) Received: from localhost.localdomain ([127.0.0.1]:56500 "EHLO linux-mips.org" rhost-flags-OK-OK-OK-FAIL) by eddie.linux-mips.org with ESMTP id S6823043Ab3F1OVNinjTG (ORCPT ); Fri, 28 Jun 2013 16:21:13 +0200 Received: from scotty.linux-mips.net (localhost.localdomain [127.0.0.1]) by scotty.linux-mips.net (8.14.5/8.14.4) with ESMTP id r5SELCY0021216; Fri, 28 Jun 2013 16:21:12 +0200 Received: (from ralf@localhost) by scotty.linux-mips.net (8.14.5/8.14.5/Submit) id r5SELATG021215; Fri, 28 Jun 2013 16:21:10 +0200 Date: Fri, 28 Jun 2013 16:21:10 +0200 From: Ralf Baechle To: Florian Fainelli Cc: Markos Chandras , Linux-MIPS Subject: Re: [PATCH] MIPS: Kconfig: Add missing MODULES dependency to VPE_LOADER Message-ID: <20130628142110.GO10727@linux-mips.org> References: <1372422327-21814-1-git-send-email-markos.chandras@imgtec.com> <20130628133111.GN10727@linux-mips.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 37207 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: ralf@linux-mips.org Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On Fri, Jun 28, 2013 at 02:40:17PM +0100, Florian Fainelli wrote: > 2013/6/28 Ralf Baechle : > > On Fri, Jun 28, 2013 at 01:25:27PM +0100, Markos Chandras wrote: > > > >> The vpe.c code uses the 'struct module' which is only available if > >> CONFIG_MODULES is selected. > >> > >> Also fixes the following build problem on a lantiq allmodconfig: > >> In file included from arch/mips/kernel/vpe.c:41:0: > >> include/linux/moduleloader.h: In function 'apply_relocate': > >> include/linux/moduleloader.h:48:63: error: dereferencing pointer > >> to incomplete type > >> include/linux/moduleloader.h: In function 'apply_relocate_add': > >> include/linux/moduleloader.h:70:63: error: dereferencing pointer > >> to incomplete type > >> > >> Signed-off-by: Markos Chandras > >> Reviewed-by: James Hogan > > > > Sigh. One more bug in the thing. It first of all shouldn't have been > > designed recycling so much code from the module loader in inapropriate > > ways. > > > > I'm going to apply the patch - but as usual whenver I have to touch the > > VPE loader, kspd or rtlx I feel like a blunt chainsaw would be the right > > way to fix this code. > > > > SPUFS is a special filesystem which was designed to use the Playstation 3's > > synergetic elements. The code is in arch/powerpc/platforms/cell/spufs > > and it's a far, cleaner interface to other processing thingies, be they > > synergetic elements, or other cores, VPEs and TCs running bare metal > > code or strage things like custom processors. > > Would not remoteproc be a simpler interface these days to load > bare-metal ELF code into one of these things? Once upon a time long before remoteproc was invented there was agreement that SPUFS would be the way to go. Yes, remoteproc might be worth a closer look. Ralf