From: Andi Kleen <andi@firstfloor.org>
To: Eliezer Tamir <eliezer.tamir@linux.intel.com>
Cc: David Miller <davem@davemloft.net>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Willem de Bruijn <willemb@google.com>,
Eric Dumazet <erdnetdev@gmail.com>,
Andi Kleen <andi@firstfloor.org>, HPA <hpa@zytor.com>,
Cody P Schafer <devel-lists@codyps.com>,
Eliezer Tamir <eliezer@tamir.org.il>
Subject: Re: [PATCH net-next 2/2] net: avoid calling sched_clock when LLS is off
Date: Fri, 28 Jun 2013 16:38:40 +0200 [thread overview]
Message-ID: <20130628143840.GS6123@two.firstfloor.org> (raw)
In-Reply-To: <20130628125934.14419.38109.stgit@ladj378.jer.intel.com>
> diff --git a/fs/select.c b/fs/select.c
> index 79b876e..3654075 100644
> --- a/fs/select.c
> +++ b/fs/select.c
> @@ -402,7 +402,7 @@ int do_select(int n, fd_set_bits *fds, struct timespec *end_time)
> poll_table *wait;
> int retval, i, timed_out = 0;
> unsigned long slack = 0;
> - unsigned int ll_flag = POLL_LL;
> + unsigned int ll_flag = ll_get_flag();
Is that a global flag? That's still the wrong level. It should
look at something in the file descriptor (preferably without
fetching any new cache lines)
-Andi
>
> +static inline unsigned int ll_get_flag(void)
> +{
> + return sysctl_net_ll_poll ? POLL_LL : 0;
> +}
next prev parent reply other threads:[~2013-06-28 14:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-28 12:59 [PATCH net-next 0/2] net: lls cleanup patches Eliezer Tamir
2013-06-28 12:59 ` [PATCH net-next 1/2] net: fix LLS debug_smp_processor_id() warning Eliezer Tamir
2013-06-28 16:51 ` Using sched_clock() for polling time limit Ben Hutchings
2013-06-29 18:50 ` Eliezer Tamir
2013-07-01 19:48 ` Ben Hutchings
2013-06-28 12:59 ` [PATCH net-next 2/2] net: avoid calling sched_clock when LLS is off Eliezer Tamir
2013-06-28 14:38 ` Andi Kleen [this message]
2013-06-28 14:54 ` Eliezer Tamir
2013-07-01 21:08 ` [PATCH net-next 0/2] net: lls cleanup patches David Miller
2013-07-02 8:38 ` Eliezer Tamir
2013-07-02 8:45 ` Eliezer Tamir
2013-07-02 9:49 ` [PATCH v2 net-next] net: convert lls to use time_in_range() Eliezer Tamir
2013-07-02 19:56 ` David Miller
2013-07-02 20:10 ` Ben Hutchings
2013-07-02 20:28 ` Eliezer Tamir
2013-07-02 20:42 ` Ben Hutchings
2013-07-03 7:00 ` Eliezer Tamir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130628143840.GS6123@two.firstfloor.org \
--to=andi@firstfloor.org \
--cc=davem@davemloft.net \
--cc=devel-lists@codyps.com \
--cc=eliezer.tamir@linux.intel.com \
--cc=eliezer@tamir.org.il \
--cc=erdnetdev@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.