Re: [bitbake][oe-core][RFC PATCH 1/2] fetch2: Add an extra check for sstate_mirrors

[Joe MacDonald <Joe.MacDonald@windriver.com>]

[-- Attachment #1: Type: text/plain, Size: 2025 bytes --]

[Re: [bitbake-devel] [bitbake][oe-core][RFC PATCH 1/2] fetch2: Add an extra check for sstate_mirrors] On 13.06.28 (Fri 18:04) Richard Purdie wrote:

> On Fri, 2013-06-28 at 12:00 -0500, Mark Hatle wrote:
> > On 6/28/13 11:56 AM, Richard Purdie wrote:
> > > On Fri, 2013-06-28 at 11:05 -0400, Joe MacDonald wrote:
> > >> BB_NO_NETWORK disables any fetching, however if we're using an external
> > >> sstate cache, we may want to be able to fetch those objects even if we are
> > >> not fetching the upstream sources.
> > >>
> > >> Signed-off-by: Joe MacDonald <joe.macdonald@windriver.com>
> > >> ---
> > >>   bitbake/lib/bb/fetch2/__init__.py |   18 +++++++++++++-----
> > >>   1 file changed, 13 insertions(+), 5 deletions(-)
> > >
> > >
> > > Bitbake's fetch module knows nothing about sstate right now and I don't
> > > see any reason to teach it about it. Why can't you just change
> > > BB_NO_NETWORK in sstate.bbclass before we call into the fetcher?
> > 
> > We considered that, but won't that then change the value potentially for other 
> > things that could be running in parallel?  Or is the namespace protection good 
> > enough for that?
> > 
> > I.e. in sstate.bbclass do a d.setVar ... call the fetch .. d.setVar (restore)?
> 
> If you look carefully you'll see sstate.bbclass does a
> bb.data.createCopy() of the datastore and only changes that before
> calling into the fetcher module. The change is only local to that copy
> and the copy only lives as long as its referenced so it should all be
> fine.

Okay, thanks for the feedback, guys.  I've re-worked this into a purely
sstate.bbclass change and verified it is still behaving nicely, I'll
mail that out to openembedded-core@lists.openembedded.org now.

-J.

> 
> Cheers,
> 
> Richard
> 
> 
> 
> _______________________________________________
> bitbake-devel mailing list
> bitbake-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/bitbake-devel

-- 
-Joe MacDonald.
:wq

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]