All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Jan Kara <jack@suse.cz>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] block: Reserve only one queue tag for sync IO if only 3 tags are available
Date: Fri, 28 Jun 2013 21:31:52 +0200	[thread overview]
Message-ID: <20130628193152.GF24293@kernel.dk> (raw)
In-Reply-To: <1372432127-9716-1-git-send-email-jack@suse.cz>

On Fri, Jun 28 2013, Jan Kara wrote:
> In case a device has three tags available we still reserve two of them
> for sync IO. That leaves only a single tag for async IO such as
> writeback from flusher thread which results in poor performance.
> 
> Allow async IO to consume two tags in case queue has three tag availabe
> to get a decent async write performance.
> 
> This patch improves streaming write performance on a machine with such disk
> from ~21 MB/s to ~52 MB/s. Also postmark throughput in presence of
> streaming writer improves from 8 to 12 transactions per second so sync
> IO doesn't seem to be harmed in presence of heavy async writer.

That's pretty crazy! Never seen a device like that. But yes, it
obviously exists, and the 2 reserved tags doesn't work well for that. So
it's an improvement.

Thanks, will queue up for 3.11.

-- 
Jens Axboe


  reply	other threads:[~2013-06-28 19:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-28 15:08 [PATCH] block: Reserve only one queue tag for sync IO if only 3 tags are available Jan Kara
2013-06-28 19:31 ` Jens Axboe [this message]
2013-06-28 20:46   ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130628193152.GF24293@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=jack@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.