[PATCH v3 1/5] rtc: mxc_rtc: Driver rework

[s.hauer@pengutronix.de (Sascha Hauer)]

On Sun, Jun 30, 2013 at 01:33:35AM +0400, Alexander Shiyan wrote:
> > > On Sat, Jun 29, 2013 at 12:40:40PM +0400, Alexander Shiyan wrote:
> > > > This patch rework mxc_rtc driver.
> > > > Major changes have been made:
> > > > - Added second clock support (optional) which permit module functionality.
> > > > - Implemented support for periodic interrupts.
> > > > - Some code have been optimized.
> > > 
> > > You won't get any further with this if you don't listen to comments.
> > > 
> > > We're at v3 and Still this patch combines many totally unrelated changes
> > > in a single patch. This was noted by Shawn and more detailed by myself.
> > 
> > Where Sascha?
> > v3 is so different than v2. Can you inline your comments in v3?

I just did that.

> 
> At the moment, the driver does not work at all, even for a boards which declared.
> I do not understand the issue of making changes if we can correct this situation 
> Please fix me.
> Once again, now driver not work at all .....

If the driver is really so broken and ugly that it can't be fixed or
only with a huge amount of work, then your option would be to replace it
completely and clearly say why you think it's broken and why we need a
new driver.

I don't think that's the case. The driver has it's deficiencies, but
they can be fixed. Many of your changes are fine, but it's really 5-10
patches you have thrown into a single patch.
This is simply not nice to people reviewing it.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |