All of lore.kernel.org
 help / color / mirror / Atom feed
From: "SZEDER Gábor" <szeder@ira.uka.de>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH 2/4] completion: add completer for status
Date: Sun, 30 Jun 2013 13:19:23 +0200	[thread overview]
Message-ID: <20130630111923.GC2294@goldbirke> (raw)
In-Reply-To: <1372429088-385-3-git-send-email-artagnon@gmail.com>

On Fri, Jun 28, 2013 at 07:48:06PM +0530, Ramkumar Ramachandra wrote:
> +	__git_complete_index_file "--with-tree=HEAD --cached --others"

The code is OK, the rest of the function is pretty straightforward,
but I think this line would warrant a sentence in the log message,
considering that at first you also wondered what '--with-tree=HEAD' is
about.

  reply	other threads:[~2013-06-30 11:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-28 14:18 [PATCH 0/4] Batch completion improvements Ramkumar Ramachandra
2013-06-28 14:18 ` [PATCH 1/4] completion: complete rebase --edit-todo Ramkumar Ramachandra
2013-06-28 14:18 ` [PATCH 2/4] completion: add completer for status Ramkumar Ramachandra
2013-06-30 11:19   ` SZEDER Gábor [this message]
2013-06-30 11:24     ` Ramkumar Ramachandra
2013-06-28 14:18 ` [PATCH 3/4] completion: add completer for rev-parse Ramkumar Ramachandra
2013-06-30 11:14   ` SZEDER Gábor
2013-06-30 11:17     ` Ramkumar Ramachandra
2013-06-30 19:03     ` Junio C Hamano
2013-07-03 10:30       ` Ramkumar Ramachandra
2013-06-28 14:18 ` [PATCH 4/4] completion: prefer to use local git-completion.bash Ramkumar Ramachandra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130630111923.GC2294@goldbirke \
    --to=szeder@ira.uka.de \
    --cc=artagnon@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.