From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH 23/66] drm/i915: Move stolen stuff to
	i915_gtt
Date: Mon, 1 Jul 2013 11:43:28 -0700
Message-ID: <20130701184328.GE4242@bwidawsk.net>
References: <1372375867-1003-1-git-send-email-ben@bwidawsk.net>
	<1372375867-1003-24-git-send-email-ben@bwidawsk.net>
	<20130630131846.GN18285@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from shiva.localdomain (unknown [209.20.75.48])
	by gabe.freedesktop.org (Postfix) with ESMTP id B3FD3E5CB7
	for <intel-gfx@lists.freedesktop.org>;
	Mon,  1 Jul 2013 11:43:36 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20130630131846.GN18285@phenom.ffwll.local>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Intel GFX <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Sun, Jun 30, 2013 at 03:18:46PM +0200, Daniel Vetter wrote:
> On Thu, Jun 27, 2013 at 04:30:24PM -0700, Ben Widawsky wrote:
> > It doesn't apply to generic VMA, so it belongs with the gtt.
> > 
> > for file in `ls drivers/gpu/drm/i915/*.c` ; do
> > 	sed -i "s/mm.stolen_base/gtt.stolen_base/" $file;
> > done
> > 
> > for file in `ls drivers/gpu/drm/i915/*.c` ; do
> > 	sed -i "s/mm.stolen/gtt.stolen/" $file;
> > done
> > 
> > Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
> 
> Before I keep on merging I'd like to clarify the plan a bit: Afaics the
> goal is to extract useful stuff shared between global gtt and ppgtt into
> i915_address_space. But I'm a bit unclear what dev_priv->mm will hold in
> the end, so I'm not sure whether moving stolen around makes sense.
> 
> Can you please elaborate on your plan a bit on how dev_priv->gtt and
> dev_priv->mm will relate in the end?
> 
> Thanks, Daniel
>
This patch is leftover from when I completely removed mm. In the high
level abstraction, the stolen memory belongs to the GTT, so I decided to
keep it. There is no other reason for the patch. We can drop it of
nobody likes it.

[snip]
-- 
Ben Widawsky, Intel Open Source Technology Center