From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 2/2] drm/i915: use drm_mm_remove_node instead of put_block
Date: Mon, 1 Jul 2013 22:28:38 +0200
Message-ID: <20130701202838.GD18285@phenom.ffwll.local>
References: <1372709154-7524-1-git-send-email-daniel.vetter@ffwll.ch>
	<1372709154-7524-2-git-send-email-daniel.vetter@ffwll.ch>
	<20130701201656.GB8080@cantiga.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from mail-ee0-f42.google.com (mail-ee0-f42.google.com [74.125.83.42])
	by gabe.freedesktop.org (Postfix) with ESMTP id 353EDE5ED5
	for <dri-devel@lists.freedesktop.org>;
	Mon,  1 Jul 2013 13:28:40 -0700 (PDT)
Received: by mail-ee0-f42.google.com with SMTP id c4so2350094eek.1
	for <dri-devel@lists.freedesktop.org>;
	Mon, 01 Jul 2013 13:28:39 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20130701201656.GB8080@cantiga.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>, Daniel Vetter <daniel.vetter@ffwll.ch>, DRI Development <dri-devel@lists.freedesktop.org>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>, David Herrmann <dh.herrmann@gmail.com>, Ben Widawsky <ben@bwidawsk.net>
List-Id: dri-devel@lists.freedesktop.org

On Mon, Jul 01, 2013 at 09:16:56PM +0100, Chris Wilson wrote:
> On Mon, Jul 01, 2013 at 10:05:54PM +0200, Daniel Vetter wrote:
> > When converting to the preallocated drm_mm_node interfaces in
> > 
> > commit dc9dd7a20fde95aa81a8307cde79c2dff9f83f3d
> > Author: Chris Wilson <chris@chris-wilson.co.uk>
> > Date:   Fri Dec 7 20:37:07 2012 +0000
> > 
> >     drm/i915: Preallocate the drm_mm_node prior to manipulating the GTT drm_mm
> > 
> > only the allocation side was converted, but not the freeing. Fix this
> > up.
> > 
> > Note that the only difference between put_block and remove_node is
> > that the former fills up the preallocation cache. Which we don't need
> > anyway and hence is just wasted space.
> > 
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Ben Widawsky <ben@bwidawsk.net>
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> 
> You learn something new every day.
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

The lack of kfree in this patch might be a problem ...

/me tries again
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch