Re: [PATCH v2 1/7] marvell-ccic: add MIPI support for marvell-ccic driver

[Jonathan Corbet <corbet@lwn.net>]

For future reference, it's nice to summarize the changes made since the
previous posting.

In a really quick scan, I immediately stumbled across this:

> @@ -1816,7 +1884,9 @@ int mccic_resume(struct mcam_camera *cam)
>  
>  	mutex_lock(&cam->s_mutex);
>  	if (cam->users > 0) {
> -		mcam_ctlr_power_up(cam);
> +		ret = mcam_ctlr_power_up(cam);
> +		if (ret)
> +			return ret;

You do see the problem here, right?  Can I ask you to please audit *all*
of your changes to be sure they don't leak locks?  This isn't the sort of
problem that should need to be pointed out twice.

Don't get me wrong, I very much appreciate the effort you have put into
getting these patches ready for merging, and things are quite close.  But
it's important to get details like this right.

Thanks,

jon