From: Joel Becker <jlbec@evilplan.org>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 2/2] ocfs2: xattr: remove useless free space checking
Date: Mon, 1 Jul 2013 15:44:44 -0700 [thread overview]
Message-ID: <20130701224443.GB965@localhost> (raw)
In-Reply-To: <51C2C4E5.1030107@oracle.com>
On Thu, Jun 20, 2013 at 05:01:25PM +0800, Jeff Liu wrote:
> On 06/20/2013 02:17 PM, Junxiao Bi wrote:
>
> > free space checking will be done in ocfs2_xattr_ibody_init().
> > So remove here.
> >
> > Signed-off-by: Junxiao Bi <junxiao.bi@oracle.com>
>
> Reviewed-by: Jie Liu <jeff.liu@oracle.com>
Acked-by: Joel Becker <jlbec@evilplan.org>
>
> > ---
> > fs/ocfs2/xattr.c | 7 -------
> > 1 file changed, 7 deletions(-)
> >
> > diff --git a/fs/ocfs2/xattr.c b/fs/ocfs2/xattr.c
> > index 3bb0708..7de1a78 100644
> > --- a/fs/ocfs2/xattr.c
> > +++ b/fs/ocfs2/xattr.c
> > @@ -2759,13 +2759,6 @@ static int ocfs2_xattr_ibody_set(struct inode *inode,
> >
> > down_write(&oi->ip_alloc_sem);
> > if (!(oi->ip_dyn_features & OCFS2_INLINE_XATTR_FL)) {
> > - if (!ocfs2_xattr_has_space_inline(inode, di)) {
> > - ret = -ENOSPC;
> > - goto out;
> > - }
> > - }
> > -
> > - if (!(oi->ip_dyn_features & OCFS2_INLINE_XATTR_FL)) {
> > ret = ocfs2_xattr_ibody_init(inode, xs->inode_bh, ctxt);
> > if (ret) {
> > if (ret != -ENOSPC)
>
>
>
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/ocfs2-devel
--
Brain: I shall pollute the water supply with this DNAdefibuliser,
turning everyone into mindless slaves.
Pinky: What about the people who drink bottled water?
Brain: Pinky, people who pay 5 dollars for a bottle of water are
already mindless slaves.
http://www.jlbec.org/
jlbec at evilplan.org
next prev parent reply other threads:[~2013-07-01 22:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-20 6:17 [Ocfs2-devel] [PATCH 1/2] ocfs2: xattr: fix inlined xattr reflink Junxiao Bi
2013-06-20 6:17 ` [Ocfs2-devel] [PATCH 2/2] ocfs2: xattr: remove useless free space checking Junxiao Bi
2013-06-20 9:01 ` Jeff Liu
2013-07-01 22:44 ` Joel Becker [this message]
2013-06-20 9:01 ` [Ocfs2-devel] [PATCH 1/2] ocfs2: xattr: fix inlined xattr reflink Jeff Liu
2013-06-20 9:15 ` Junxiao Bi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130701224443.GB965@localhost \
--to=jlbec@evilplan.org \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.