From: Wanpeng Li <liwanp@linux.vnet.ibm.com>
To: Christoph Lameter <cl@linux.com>
Cc: Pekka Enberg <penberg@kernel.org>, Matt Mackall <mpm@selenic.com>,
Glauber Costa <glommer@parallels.com>,
Andrew Morton <akpm@linux-foundation.org>,
Joonsoo Kim <js1304@gmail.com>,
David Rientjes <rientjes@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] mm/slab: Fix drain freelist excessively
Date: Tue, 2 Jul 2013 07:45:13 +0800 [thread overview]
Message-ID: <20130701234513.GB14358@hacker.(null)> (raw)
In-Reply-To: <0000013f9aea494f-7a5fe6c7-47d2-42a9-bbe6-5dbc85dab0a5-000000@email.amazonses.com>
On Mon, Jul 01, 2013 at 03:46:52PM +0000, Christoph Lameter wrote:
>On Mon, 24 Jun 2013, Wanpeng Li wrote:
>
>> The drain_freelist is called to drain slabs_free lists for cache reap,
>> cache shrink, memory hotplug callback etc. The tofree parameter is the
>> number of slab objects to free instead of the number of slabs to free.
>
>Well its intended to be the number of slabs to free. The patch does not
>fix the callers that pass the number of slabs.
>
>I think the best approach would be to fix the callers that pass # of
>objects. Make sure they pass # of slabs.
>
Good point, I will fix it in next version.
Regards,
Wanpeng Li
>--
>To unsubscribe, send a message with 'unsubscribe linux-mm' in
>the body to majordomo@kvack.org. For more info on Linux MM,
>see: http://www.linux-mm.org/ .
>Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2013-07-01 23:45 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-24 10:23 [PATCH 1/3] mm/slab: Fix drain freelist excessively Wanpeng Li
2013-06-24 10:23 ` Wanpeng Li
2013-06-24 10:23 ` [PATCH 2/3] mm/slab: Sharing s_next and s_stop between slab and slub Wanpeng Li
2013-06-24 10:23 ` Wanpeng Li
2013-06-24 21:23 ` David Rientjes
2013-06-24 21:23 ` David Rientjes
2013-06-27 0:21 ` Wanpeng Li
2013-06-27 0:21 ` Wanpeng Li
2013-07-01 15:48 ` Christoph Lameter
2013-07-01 15:48 ` Christoph Lameter
2013-07-01 23:49 ` Wanpeng Li
2013-07-01 23:49 ` Wanpeng Li
2013-07-07 16:41 ` Pekka Enberg
2013-07-07 16:41 ` Pekka Enberg
2013-07-08 0:16 ` Wanpeng Li
2013-07-08 8:03 ` Pekka Enberg
2013-07-08 8:03 ` Pekka Enberg
2013-07-08 0:16 ` Wanpeng Li
2013-06-24 10:23 ` [PATCH 3/3] mm/slab: Fix /proc/slabinfo unwriteable for slab Wanpeng Li
2013-06-24 10:23 ` Wanpeng Li
2013-07-01 15:49 ` Christoph Lameter
2013-07-01 15:49 ` Christoph Lameter
2013-07-01 23:43 ` Wanpeng Li
2013-07-01 23:43 ` Wanpeng Li
2013-07-01 15:46 ` [PATCH 1/3] mm/slab: Fix drain freelist excessively Christoph Lameter
2013-07-01 15:46 ` Christoph Lameter
2013-07-01 23:45 ` Wanpeng Li
2013-07-01 23:45 ` Wanpeng Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20130701234513.GB14358@hacker.(null)' \
--to=liwanp@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=glommer@parallels.com \
--cc=js1304@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.