From mboxrd@z Thu Jan 1 00:00:00 1970 From: majianpeng Subject: [PATCH 2/3] ceph: update atime after read-operation. Date: Tue, 2 Jul 2013 13:45:08 +0800 Message-ID: <201307021345043628495@gmail.com> Reply-To: majianpeng Mime-Version: 1.0 Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: base64 Return-path: Sender: linux-kernel-owner@vger.kernel.org To: sage Cc: ceph-devel , linux-kernel List-Id: ceph-devel.vger.kernel.org Tm93IGNlcGggZG9uJ3Qgc3VwcG9ydCB1cGRhdGluZyBhdGltZSBhZnRlciByZWFkLW9wZXJhdGlv biBpZiB0aGUgb3Blbg0KbW9kZSBpcyBDRVBIX0NBUF9GSUxFX1JELlRoZXJlIGFyZSB0d28gcmVh c29uczoNCjE6aW4gY2xpZW50IG9mIGZzLGl0IGRvbid0IHNldCBkaXJ0eSBjYXAgb2YgQ0VQSF9D QVBfRklMRV9SRC4NCjI6aW4gbWRzLGl0IG9ubHkgdXBkYXRlIHRoZSBhdGltZSBpZiB0aGUgY29u ZGl0aW9uDQoiZGlydHkgJiAoQ0VQSF9DQVBfRklMRV9FWENMfENFUEhfQ0FQX0ZJTEVfV1IpIGlz IHRydWUuDQpCdXQgaWYgd2UgY2FuIHJlYWQsIHdlIGNhbiB1cGRhdGUgYXRpbWUuIFRoaXMgcGF0 Y2ggb25seSBtb2RpZnkgY2xpZW50IHRvDQpzdXBwb3J0Lg0KDQpTaWduZWQtb2ZmLWJ5OiBKaWFu cGVuZyBNYSA8bWFqaWFucGVuZ0BnbWFpbC5jb20+DQotLS0NCiBmcy9jZXBoL2ZpbGUuYyB8IDkg KysrKysrKysrDQogMSBmaWxlIGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygrKQ0KDQpkaWZmIC0tZ2l0 IGEvZnMvY2VwaC9maWxlLmMgYi9mcy9jZXBoL2ZpbGUuYw0KaW5kZXggODdkZjE1YS4uOWRhZWE3 MCAxMDA2NDQNCi0tLSBhL2ZzL2NlcGgvZmlsZS5jDQorKysgYi9mcy9jZXBoL2ZpbGUuYw0KQEAg LTY3Miw2ICs2NzIsMTUgQEAgYWdhaW46DQogb3V0Og0KIAlkb3V0KCJhaW9fcmVhZCAlcCAlbGx4 LiVsbHggZHJvcHBpbmcgY2FwIHJlZnMgb24gJXMgPSAlZFxuIiwNCiAJICAgICBpbm9kZSwgY2Vw aF92aW5vcChpbm9kZSksIGNlcGhfY2FwX3N0cmluZyhnb3QpLCAoaW50KXJldCk7DQorDQorCWlm IChyZXQgPj0gMCkgew0KKwkJaW50IGRpcnR5Ow0KKwkJc3Bpbl9sb2NrKCZjaS0+aV9jZXBoX2xv Y2spOw0KKwkJZGlydHkgPSBfX2NlcGhfbWFya19kaXJ0eV9jYXBzKGNpLCBDRVBIX0NBUF9GSUxF X1JEKTsNCisJCXNwaW5fdW5sb2NrKCZjaS0+aV9jZXBoX2xvY2spOw0KKwkJaWYgKGRpcnR5KQ0K KwkJCV9fbWFya19pbm9kZV9kaXJ0eShpbm9kZSwgZGlydHkpOw0KKwl9DQogCWNlcGhfcHV0X2Nh cF9yZWZzKGNpLCBnb3QpOw0KIA0KIAlpZiAoY2hlY2tlb2YgJiYgcmV0ID49IDApIHsNCi0tIA0K MS44LjEuMg0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752830Ab3GBFpU (ORCPT ); Tue, 2 Jul 2013 01:45:20 -0400 Received: from mail-pa0-f48.google.com ([209.85.220.48]:41733 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752238Ab3GBFpP (ORCPT ); Tue, 2 Jul 2013 01:45:15 -0400 Date: Tue, 2 Jul 2013 13:45:08 +0800 From: majianpeng To: sage Cc: ceph-devel , linux-kernel Reply-To: majianpeng Subject: [PATCH 2/3] ceph: update atime after read-operation. X-Priority: 3 X-GUID: BC88863F-2F25-4DA6-B26E-9D51D559E9AA X-Has-Attach: no X-Mailer: Foxmail 7.0.1.90[en] Mime-Version: 1.0 Message-ID: <201307021345043628495@gmail.com> Content-Type: text/plain; charset="gb2312" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id r625jdLU005632 Now ceph don't support updating atime after read-operation if the open mode is CEPH_CAP_FILE_RD.There are two reasons: 1:in client of fs,it don't set dirty cap of CEPH_CAP_FILE_RD. 2:in mds,it only update the atime if the condition "dirty & (CEPH_CAP_FILE_EXCL|CEPH_CAP_FILE_WR) is true. But if we can read, we can update atime. This patch only modify client to support. Signed-off-by: Jianpeng Ma --- fs/ceph/file.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/fs/ceph/file.c b/fs/ceph/file.c index 87df15a..9daea70 100644 --- a/fs/ceph/file.c +++ b/fs/ceph/file.c @@ -672,6 +672,15 @@ again: out: dout("aio_read %p %llx.%llx dropping cap refs on %s = %d\n", inode, ceph_vinop(inode), ceph_cap_string(got), (int)ret); + + if (ret >= 0) { + int dirty; + spin_lock(&ci->i_ceph_lock); + dirty = __ceph_mark_dirty_caps(ci, CEPH_CAP_FILE_RD); + spin_unlock(&ci->i_ceph_lock); + if (dirty) + __mark_inode_dirty(inode, dirty); + } ceph_put_cap_refs(ci, got); if (checkeof && ret >= 0) { -- 1.8.1.2 {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I