From: Dan Carpenter <dan.carpenter@oracle.com>
To: fery@cypress.com
Cc: linux-input@vger.kernel.org
Subject: re: Input: cyttsp4 - SPI driver for Cypress TMA4XX touchscreen devices
Date: Wed, 3 Jul 2013 00:47:31 +0300 [thread overview]
Message-ID: <20130702214731.GD1598@elgon.mountain> (raw)
Hello Ferruh Yigit,
The patch 67bf12ca50d5: "Input: cyttsp4 - SPI driver for Cypress
TMA4XX touchscreen devices" from Jun 30, 2013, leads to the following
Smatch warning:
"drivers/input/touchscreen/cyttsp4_spi.c:66 cyttsp_spi_xfer()
warn: impossible condition '(reg > 255) => (0-255 > 255)'"
drivers/input/touchscreen/cyttsp4_spi.c
66 if (reg > 255)
^^^^^^^^^
"reg" is unsigned char so 255 is the max it can be.
67 wr_buf[0] = op + CY_SPI_A8_BIT;
68 else
69 wr_buf[0] = op;
regards,
dan carpenter
next reply other threads:[~2013-07-02 21:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-02 21:47 Dan Carpenter [this message]
2013-07-03 13:24 ` Input: cyttsp4 - SPI driver for Cypress TMA4XX touchscreen devices Ferruh Yigit
2013-07-03 13:52 ` Dan Carpenter
2013-07-03 20:36 ` [PATCH] Input: cyttsp4 - use 16bit address for I2C/SPI communication Ferruh Yigit
2013-07-04 12:25 ` Javier Martinez Canillas
2013-07-07 5:08 ` Dmitry Torokhov
[not found] <20130704235117.733726609A1@gitolite.kernel.org>
2013-07-07 19:15 ` Input: cyttsp4 - SPI driver for Cypress TMA4XX touchscreen devices Geert Uytterhoeven
2013-07-07 19:15 ` Geert Uytterhoeven
2013-07-09 7:12 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130702214731.GD1598@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=fery@cypress.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.