From mboxrd@z Thu Jan 1 00:00:00 1970 From: majianpeng Subject: Re: Re: [PATCH 1/3] mds: update atime if client can read. Date: Wed, 3 Jul 2013 09:25:39 +0800 Message-ID: <201307030925331606702@gmail.com> References: <201307021345090019137@gmail.com>, Reply-To: majianpeng Mime-Version: 1.0 Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: base64 Return-path: Sender: linux-kernel-owner@vger.kernel.org To: sage Cc: ceph-devel , linux-kernel List-Id: ceph-devel.vger.kernel.org Pk9uIFR1ZSwgMiBKdWwgMjAxMywgbWFqaWFucGVuZyB3cm90ZToNCj4+IE5vdywgdXBkYXRlIGF0 aW1lIG9ubHkgZm9yIENFUEhfQ0FQX0ZJTEVfRVhDTC5DaGFuZ2UgdGhpcyBpZg0KPj4gQ0VQSF9D QVBfRklMRV9SRC4NCj4NCj5DYW4gd2UgaW50cm9kdWNlIGEgZ2xvYmFsIGNvbmZpZyBvcHRvaW4g KGJvb2wgbWRzX2F0aW1lIGluIA0KPmNvbW1vbi9jb25maWdfb3B0cy5oLCBtYXliZSkgc28gdGhh dCB1c2VycyBjYW4gdHVybiB0aGlzIG9mZj8gIEFuZC9vciBhZGQgDQo+YSAncmVsYXRpbWUnIG9w dGlvbj8gIE1vcmUgdXNlcnMgd29uJ3Qgd2FudCB0aGlzIGFzIGl0IGlzIHZlcnkgZXhwZW5zaXZl IA0KPnRvIG1haW50YWluIHRoaXMgZXh0cmEgbGV2ZWwgb2YgbWV0YWRhdGEuDQo+DQpJIGRvbid0 IGtub3cgb3RoZXIgY2xpZW50IGV4Y2VwdCBjZXBoZnMuU28gdGhlIHBhdGNoIGlzIGZyb20gdGhl IHZpZXcgb2YgdXNpbmcgY2VwaGZzLg0KRm9yIGNlcGhmcyx3ZSBjYW4gbW91bnQgdXNpbmcgJ25v YXRpbWUnIHRvIGluZGljYXRlIGRvbid0IHVwZGF0ZSBhdGltZS4NCkJ1dCBmb3IgdGhlIG90aGVy IGNsaWVudCwgaSBkb24ndCBrbm93Lg0KSSB0aGluayB0aGlzIHNob3VsZCBjb250cm9sZWQgYnkg Y2xpZW50IG5vdCBzZXJ2ZXIuDQoNCj5UaGF0IGFzaWRlLCB0aGlzIGFwcHJvYWNoIGxvb2tzIHJp Z2h0IHRvIG1lLiA6KQ0KPg0KPlRoYW5rcyENCj5zYWdlDQo+DQo+DQo+ID4gDQo+PiBTaWduZWQt b2ZmLWJ5OiBKaWFucGVuZyBNYSA8bWFqaWFucGVuZ0BnbWFpbC5jb20+DQo+PiAtLS0NCj4+ICBz cmMvbWRzL0xvY2tlci5jYyB8IDE1ICsrKysrKysrKy0tLS0tLQ0KPj4gIDEgZmlsZSBjaGFuZ2Vk LCA5IGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pDQo+PiANCj4+IGRpZmYgLS1naXQgYS9z cmMvbWRzL0xvY2tlci5jYyBiL3NyYy9tZHMvTG9ja2VyLmNjDQo+PiBpbmRleCAzMGUwMTRhLi41 OGY5NTNmIDEwMDY0NA0KPj4gLS0tIGEvc3JjL21kcy9Mb2NrZXIuY2MNCj4+ICsrKyBiL3NyYy9t ZHMvTG9ja2VyLmNjDQo+PiBAQCAtMjY3Niw4ICsyNjc2LDkgQEAgdm9pZCBMb2NrZXI6Ol9kb19z bmFwX3VwZGF0ZShDSW5vZGUgKmluLCBzbmFwaWRfdCBzbmFwLCBpbnQgZGlydHksIHNuYXBpZF90 IGZvbGwNCj4+ICB2b2lkIExvY2tlcjo6X3VwZGF0ZV9jYXBfZmllbGRzKENJbm9kZSAqaW4sIGlu dCBkaXJ0eSwgTUNsaWVudENhcHMgKm0sIGlub2RlX3QgKnBpKQ0KPj4gIHsNCj4+ICAgIC8vIGZp bGUNCj4+ICsgIHV0aW1lX3QgYXRpbWUgPSBtLT5nZXRfYXRpbWUoKTsNCj4+ICsNCj4+ICAgIGlm IChkaXJ0eSAmIChDRVBIX0NBUF9GSUxFX0VYQ0x8Q0VQSF9DQVBfRklMRV9XUikpIHsNCj4+IC0g ICAgdXRpbWVfdCBhdGltZSA9IG0tPmdldF9hdGltZSgpOw0KPj4gICAgICB1dGltZV90IG10aW1l ID0gbS0+Z2V0X210aW1lKCk7DQo+PiAgICAgIHV0aW1lX3QgY3RpbWUgPSBtLT5nZXRfY3RpbWUo KTsNCj4+ICAgICAgdWludDY0X3Qgc2l6ZSA9IG0tPmdldF9zaXplKCk7DQo+PiBAQCAtMjcwMCwx MSArMjcwMSw3IEBAIHZvaWQgTG9ja2VyOjpfdXBkYXRlX2NhcF9maWVsZHMoQ0lub2RlICppbiwg aW50IGRpcnR5LCBNQ2xpZW50Q2FwcyAqbSwgaW5vZGVfdCAqDQo+PiAgICAgICAgcGktPnNpemUg PSBzaXplOw0KPj4gICAgICAgIHBpLT5yc3RhdC5yYnl0ZXMgPSBzaXplOw0KPj4gICAgICB9DQo+ PiAtICAgIGlmICgoZGlydHkgJiBDRVBIX0NBUF9GSUxFX0VYQ0wpICYmIGF0aW1lICE9IHBpLT5h dGltZSkgew0KPj4gLSAgICAgIGRvdXQoNykgPDwgIiAgYXRpbWUgIiA8PCBwaS0+YXRpbWUgPDwg IiAtPiAiIDw8IGF0aW1lDQo+PiAtCSAgICAgIDw8ICIgZm9yICIgPDwgKmluIDw8IGRlbmRsOw0K Pj4gLSAgICAgIHBpLT5hdGltZSA9IGF0aW1lOw0KPj4gLSAgICB9DQo+PiArICAgIA0KPj4gICAg ICBpZiAoKGRpcnR5ICYgQ0VQSF9DQVBfRklMRV9FWENMKSAmJg0KPj4gIAljZXBoX3NlcV9jbXAo cGktPnRpbWVfd2FycF9zZXEsIG0tPmdldF90aW1lX3dhcnBfc2VxKCkpIDwgMCkgew0KPj4gICAg ICAgIGRvdXQoNykgPDwgIiAgdGltZV93YXJwX3NlcSAiIDw8IHBpLT50aW1lX3dhcnBfc2VxIDw8 ICIgLT4gIiA8PCBtLT5nZXRfdGltZV93YXJwX3NlcSgpDQo+PiBAQCAtMjcxMiw2ICsyNzA5LDEy IEBAIHZvaWQgTG9ja2VyOjpfdXBkYXRlX2NhcF9maWVsZHMoQ0lub2RlICppbiwgaW50IGRpcnR5 LCBNQ2xpZW50Q2FwcyAqbSwgaW5vZGVfdCAqDQo+PiAgICAgICAgcGktPnRpbWVfd2FycF9zZXEg PSBtLT5nZXRfdGltZV93YXJwX3NlcSgpOw0KPj4gICAgICB9DQo+PiAgICB9DQo+PiArICANCj4+ ICsgIGlmICgoZGlydHkgJiBDRVBIX0NBUF9GSUxFX1JEKSAmJiBhdGltZSA+IHBpLT5hdGltZSkg ew0KPj4gKyAgICAgIGRvdXQoNykgPDwgIiAgYXRpbWUgIiA8PCBwaS0+YXRpbWUgPDwgIiAtPiAi IDw8IGF0aW1lDQo+PiArCSAgICAgIDw8ICIgZm9yICIgPDwgKmluIDw8IGRlbmRsOw0KPj4gKyAg ICAgIHBpLT5hdGltZSA9IGF0aW1lOw0KPj4gKyAgfQ0KPj4gICAgLy8gYXV0aA0KPj4gICAgaWYg KGRpcnR5ICYgQ0VQSF9DQVBfQVVUSF9FWENMKSB7DQo+PiAgICAgIGlmIChtLT5oZWFkLnVpZCAh PSBwaS0+dWlkKSB7DQo+PiAtLSANCj4+IDEuOC4zLnJjMS40NC5nYjM4N2M3Nw0KPj4g From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754563Ab3GCBZq (ORCPT ); Tue, 2 Jul 2013 21:25:46 -0400 Received: from mail-pa0-f43.google.com ([209.85.220.43]:63465 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751281Ab3GCBZp (ORCPT ); Tue, 2 Jul 2013 21:25:45 -0400 Date: Wed, 3 Jul 2013 09:25:39 +0800 From: majianpeng To: sage Cc: ceph-devel , linux-kernel Reply-To: majianpeng Subject: Re: Re: [PATCH 1/3] mds: update atime if client can read. References: <201307021345090019137@gmail.com>, X-Priority: 3 X-GUID: 0891D6D3-5563-402D-BAB6-682D5F8A4939 X-Has-Attach: no X-Mailer: Foxmail 7.0.1.90[en] Mime-Version: 1.0 Message-ID: <201307030925331606702@gmail.com> Content-Type: text/plain; charset="gb2312" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id r631PwaG011592 >On Tue, 2 Jul 2013, majianpeng wrote: >> Now, update atime only for CEPH_CAP_FILE_EXCL.Change this if >> CEPH_CAP_FILE_RD. > >Can we introduce a global config optoin (bool mds_atime in >common/config_opts.h, maybe) so that users can turn this off? And/or add >a 'relatime' option? More users won't want this as it is very expensive >to maintain this extra level of metadata. > I don't know other client except cephfs.So the patch is from the view of using cephfs. For cephfs,we can mount using 'noatime' to indicate don't update atime. But for the other client, i don't know. I think this should controled by client not server. >That aside, this approach looks right to me. :) > >Thanks! >sage > > > > >> Signed-off-by: Jianpeng Ma >> --- >> src/mds/Locker.cc | 15 +++++++++------ >> 1 file changed, 9 insertions(+), 6 deletions(-) >> >> diff --git a/src/mds/Locker.cc b/src/mds/Locker.cc >> index 30e014a..58f953f 100644 >> --- a/src/mds/Locker.cc >> +++ b/src/mds/Locker.cc >> @@ -2676,8 +2676,9 @@ void Locker::_do_snap_update(CInode *in, snapid_t snap, int dirty, snapid_t foll >> void Locker::_update_cap_fields(CInode *in, int dirty, MClientCaps *m, inode_t *pi) >> { >> // file >> + utime_t atime = m->get_atime(); >> + >> if (dirty & (CEPH_CAP_FILE_EXCL|CEPH_CAP_FILE_WR)) { >> - utime_t atime = m->get_atime(); >> utime_t mtime = m->get_mtime(); >> utime_t ctime = m->get_ctime(); >> uint64_t size = m->get_size(); >> @@ -2700,11 +2701,7 @@ void Locker::_update_cap_fields(CInode *in, int dirty, MClientCaps *m, inode_t * >> pi->size = size; >> pi->rstat.rbytes = size; >> } >> - if ((dirty & CEPH_CAP_FILE_EXCL) && atime != pi->atime) { >> - dout(7) << " atime " << pi->atime << " -> " << atime >> - << " for " << *in << dendl; >> - pi->atime = atime; >> - } >> + >> if ((dirty & CEPH_CAP_FILE_EXCL) && >> ceph_seq_cmp(pi->time_warp_seq, m->get_time_warp_seq()) < 0) { >> dout(7) << " time_warp_seq " << pi->time_warp_seq << " -> " << m->get_time_warp_seq() >> @@ -2712,6 +2709,12 @@ void Locker::_update_cap_fields(CInode *in, int dirty, MClientCaps *m, inode_t * >> pi->time_warp_seq = m->get_time_warp_seq(); >> } >> } >> + >> + if ((dirty & CEPH_CAP_FILE_RD) && atime > pi->atime) { >> + dout(7) << " atime " << pi->atime << " -> " << atime >> + << " for " << *in << dendl; >> + pi->atime = atime; >> + } >> // auth >> if (dirty & CEPH_CAP_AUTH_EXCL) { >> if (m->head.uid != pi->uid) { >> -- >> 1.8.3.rc1.44.gb387c77 >> {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I