From: Oleg Nesterov <oleg@redhat.com>
To: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
"zhangwei(Jovi)" <jovi.zhangwei@huawei.com>,
Jiri Olsa <jolsa@redhat.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: PATCH? trace_remove_event_call() should fail if call is active
Date: Wed, 3 Jul 2013 19:54:20 +0200 [thread overview]
Message-ID: <20130703175420.GA25668@redhat.com> (raw)
In-Reply-To: <20130703172029.GA14309@redhat.com>
On 07/03, Oleg Nesterov wrote:
>
> IOW. So far _I think_ we just need the additional changes in
> trace_remove_event_call() if it succeeds (with the patch I sent)
> to prevent the races like above, but I didn't even try to think
> about this problem.
And I guess greatly underestimated the problem(s). When I look at
this code now, it seems that, say, event_enable_write() will use
the already freed ftrace_event_file in this case.
Still I think this is another (although closely related) problem.
> Or I missed your point completely?
Yes?
Oleg.
next prev parent reply other threads:[~2013-07-03 17:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-25 8:16 [PATCH 2/2] tracing/uprobes: disallow unregister trace_uprobe when trace_uprobe is in use zhangwei(Jovi)
2013-06-25 17:23 ` Oleg Nesterov
[not found] ` <20130626185205.GA27894@redhat.com>
[not found] ` <51CBEE3E.70103@hitachi.com>
[not found] ` <20130627161716.GA17889@redhat.com>
[not found] ` <51CCF8BA.4030601@hitachi.com>
[not found] ` <20130628180946.GA30838@redhat.com>
[not found] ` <51D16E1D.5040904@hitachi.com>
[not found] ` <20130702190037.GA6289@redhat.com>
2013-07-02 19:34 ` PATCH? trace_remove_event_call() should fail if call is active Oleg Nesterov
2013-07-02 21:04 ` Steven Rostedt
2013-07-02 21:35 ` Steven Rostedt
2013-07-02 21:38 ` Oleg Nesterov
2013-07-02 21:41 ` Oleg Nesterov
2013-07-02 22:23 ` Oleg Nesterov
2013-07-02 22:49 ` Steven Rostedt
2013-07-02 22:53 ` Steven Rostedt
2013-07-03 2:42 ` Masami Hiramatsu
2013-07-03 2:57 ` Steven Rostedt
2013-07-03 3:12 ` Masami Hiramatsu
2013-07-03 17:20 ` Oleg Nesterov
2013-07-03 17:54 ` Oleg Nesterov [this message]
2013-07-03 18:02 ` Steven Rostedt
2013-07-03 19:17 ` Oleg Nesterov
2013-07-03 20:34 ` Steven Rostedt
2013-07-03 20:36 ` Steven Rostedt
2013-07-03 23:11 ` Oleg Nesterov
2013-07-03 22:18 ` Oleg Nesterov
2013-07-04 0:19 ` Steven Rostedt
2013-07-03 21:02 ` Steven Rostedt
2013-07-04 4:25 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130703175420.GA25668@redhat.com \
--to=oleg@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=jovi.zhangwei@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.