From: Oleg Nesterov <oleg@redhat.com>
To: Denys Vlasenko <dvlasenk@redhat.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Change SIGPIPE's siginfo.si_code from SI_USER to SI_KERNEL.
Date: Wed, 3 Jul 2013 21:54:52 +0200 [thread overview]
Message-ID: <20130703195452.GA6930@redhat.com> (raw)
In-Reply-To: <1372880335-23755-1-git-send-email-dvlasenk@redhat.com>
On 07/03, Denys Vlasenko wrote:
>
> @@ -514,7 +514,7 @@ pipe_write(struct kiocb *iocb, const struct iovec *_iov,
> __pipe_lock(pipe);
>
> if (!pipe->readers) {
> - send_sig(SIGPIPE, current, 0);
> + send_sig(SIGPIPE, current, 1);
Honestly, I simply have no idea what makes more sense in this case...
But I am not sure about this user-visible change. It can break
something and for what?
And if you do this then I guess you should also change net/.
Oleg.
next prev parent reply other threads:[~2013-07-03 19:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-03 19:38 [PATCH] Change SIGPIPE's siginfo.si_code from SI_USER to SI_KERNEL Denys Vlasenko
2013-07-03 19:54 ` Oleg Nesterov [this message]
2013-07-04 7:16 ` Denys Vlasenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130703195452.GA6930@redhat.com \
--to=oleg@redhat.com \
--cc=dvlasenk@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.