From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3] Makefile: fix readelf usage
Date: Thu, 4 Jul 2013 14:09:09 +0200 [thread overview]
Message-ID: <20130704140909.473d6092@lilith> (raw)
In-Reply-To: <1372590906-75089-4-git-send-email-andreas.devel@googlemail.com>
Hi Andreas,
On Sun, 30 Jun 2013 13:15:06 +0200, Andreas Bie?mann
<andreas.devel@googlemail.com> wrote:
> Some OS (like OS X) do not provide a generic readelf. We should enforce to use
> the toochain provided readelf instead, to do so use $(CROSS_COMPILE)readelf.
>
> Signed-off-by: Andreas Bie?mann <andreas.devel@googlemail.com>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index ba1c10b..446c2f8 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -747,7 +747,7 @@ endif # config.mk
> # ARM relocations should all be R_ARM_RELATIVE.
> checkarmreloc: $(obj)u-boot
> @if test "R_ARM_RELATIVE" != \
> - "`readelf -r $< | cut -d ' ' -f 4 | grep R_ARM | sort -u`"; \
> + "`$(CROSS_COMPILE)readelf -r $< | cut -d ' ' -f 4 | grep R_ARM | sort -u`"; \
> then echo "$< contains relocations other than \
> R_ARM_RELATIVE"; false; fi
Acked-by: Albert ARIBAUD <albert.u.boot@aribaud.net>
Tom, do I take this in u-boot-arm and then deliver this later in my PR,
or do you want to pick it directly in mainline?
Amicalement,
--
Albert.
next prev parent reply other threads:[~2013-07-04 12:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-30 11:15 [U-Boot] [PATCH 0/3] Adopt u-boot build to OS X Andreas Bießmann
2013-06-30 11:15 ` [U-Boot] [PATCH 1/3] lib/rsa/rsa-sig.c: compile on " Andreas Bießmann
2013-07-01 18:58 ` Lubomir Popov
2013-07-03 14:15 ` Simon Glass
2013-06-30 11:15 ` [U-Boot] [PATCH 2/3] tools/proftool: add missing definition Andreas Bießmann
2013-07-01 18:45 ` Jeroen Hofstee
2013-07-01 20:12 ` Jeroen Hofstee
2013-07-02 6:39 ` Andreas Bießmann
2013-07-01 18:59 ` Lubomir Popov
2013-06-30 11:15 ` [U-Boot] [PATCH 3/3] Makefile: fix readelf usage Andreas Bießmann
2013-07-01 19:00 ` Lubomir Popov
2013-07-04 12:09 ` Albert ARIBAUD [this message]
2013-07-04 13:25 ` Andreas Bießmann
2013-07-04 14:02 ` Albert ARIBAUD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130704140909.473d6092@lilith \
--to=albert.u.boot@aribaud.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.