From: Oleg Nesterov <oleg@redhat.com>
To: "zhangwei(Jovi)" <jovi.zhangwei@huawei.com>
Cc: Namhyung Kim <namhyung@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
Ingo Molnar <mingo@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2 v5 typo updated] tracing/uprobes: Support ftrace_event_file base multibuffer
Date: Thu, 4 Jul 2013 19:57:12 +0200 [thread overview]
Message-ID: <20130704175712.GC2046@redhat.com> (raw)
In-Reply-To: <51D52BFA.9030600@huawei.com>
On 07/04, zhangwei(Jovi) wrote:
>
> On 2013/7/4 15:41, Namhyung Kim wrote:
> >>
> >> Even though we allow multi-uprobes instances now,
> >> but TP_FLAG_PROFILE/TP_FLAG_TRACE are still mutually exclusive
> >> in probe_event_enable currently, this means we cannot allow
> >> one user is using uprobe-tracer, and another user is using
> >> perf-probe on same uprobe concurrently.
> >> (Perhaps this will be fix in future, kprobe dont't have this
> >> limitation now)
> >
> > So why does this limitation exist? Didn't we support this kind of thing
> > in the original code?
For no reason.
> Yes, it existed(maybe not exist before uprobe pre-filter work),
No, it was always here and I never understood it.
> because uprobe filter
> is associated with trace_uprobe tightly at present, so we cannot assign
> TP_FLAG_PROFILE/TP_FLAG_TRACE for same trace_uprobe with different filter.
More precisely, TRACE_REG_REGISTER should participate (inc/dec nr_systemwide)
if CONFIG_PERF_EVENTS.
> Perhaps we need to remove the limitation in future.
Yes, I'll remove it.
Oleg.
prev parent reply other threads:[~2013-07-04 18:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-04 6:53 [PATCH 1/2 v5] tracing/uprobes: Support ftrace_event_file base multibuffer zhangwei(Jovi)
2013-07-04 7:01 ` [PATCH 1/2 v5 typo updated] " zhangwei(Jovi)
2013-07-04 7:41 ` Namhyung Kim
2013-07-04 8:02 ` zhangwei(Jovi)
2013-07-04 17:57 ` Oleg Nesterov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130704175712.GC2046@redhat.com \
--to=oleg@redhat.com \
--cc=fweisbec@gmail.com \
--cc=jovi.zhangwei@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=rostedt@goodmis.org \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.