From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] Added support for On Chip OTP in i.MX23/28
Date: Fri, 5 Jul 2013 10:08:42 +0200 [thread overview]
Message-ID: <20130705080842.GG2959@lukather> (raw)
In-Reply-To: <1372855154-8422-3-git-send-email-cb@sgoc.de>
Hi Christoph,
On Wed, Jul 03, 2013 at 02:39:13PM +0200, Christoph G. Baumann wrote:
> From: "Christoph G. Baumann" <cb@sgoc.de>
>
> Signed-off-by: Christoph G. Baumann <cb@sgoc.de>
> ---
> arch/arm/mach-mxs/include/mach/mx23-ocotp.h | 311 +++++++++++++++++++++++++++
> arch/arm/mach-mxs/include/mach/mx28-ocotp.h | 239 ++++++++++++++++++++
> 2 files changed, 550 insertions(+)
> create mode 100644 arch/arm/mach-mxs/include/mach/mx23-ocotp.h
> create mode 100644 arch/arm/mach-mxs/include/mach/mx28-ocotp.h
Ah. Here are your includes.
Two things then:
- Like I said in my previous mail, the include/mach doesn't play well
with the multi-platform kernels. How should you choose one header
instead of another in this case, or even one mach/ directory or
another if you have several platforms enabled.
- From what I can recall, the OCOTP is only something like a few MMIO
bytes to access, with a bit of logic when writing, but nothing more
than a few registers and a few bits in there. Are you sure you
actually need 550 lines of define for only a dozen defines or so?
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130705/db5ffe9a/attachment.sig>
next prev parent reply other threads:[~2013-07-05 8:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-03 12:39 [PATCH 0/3] Added support for On Chip OTP in i.MX23/28 Christoph G. Baumann
2013-07-03 12:39 ` [PATCH 1/3] " Christoph G. Baumann
2013-07-05 8:03 ` Maxime Ripard
2013-07-03 12:39 ` [PATCH 2/3] " Christoph G. Baumann
2013-07-05 8:08 ` Maxime Ripard [this message]
2013-07-03 12:39 ` [PATCH 3/3] " Christoph G. Baumann
2013-07-05 8:14 ` Maxime Ripard
2013-07-05 7:38 ` [PATCH 0/3] " Maxime Ripard
2013-07-07 21:19 ` Christoph G. Baumann
2013-07-17 16:27 ` [PATCH v2 0/3] mxs: add driver for On Chip OTP Christoph G. Baumann
2013-07-17 16:27 ` [PATCH v2 1/3] mxs: enable ocotp in device tree Christoph G. Baumann
2013-07-17 16:27 ` [PATCH v2 2/3] mxs: register clkdev "hbus" as it is required by OCOTP Christoph G. Baumann
2013-07-17 16:27 ` [PATCH v2 3/3] mxs: added driver for OCOTP in i.MX23 and i.MX28 Christoph G. Baumann
2013-07-17 19:26 ` Sascha Hauer
2013-07-17 21:43 ` Christoph G. Baumann
2013-07-18 6:36 ` Sascha Hauer
2013-07-18 15:14 ` Christoph G. Baumann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130705080842.GG2959@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.