All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] gcc: apply PowerPC patch when needed
Date: Fri, 5 Jul 2013 15:01:37 +0200	[thread overview]
Message-ID: <20130705150137.773e3ad7@skate> (raw)
In-Reply-To: <51D6C2AA.8070703@zacarias.com.ar>

Dear Gustavo Zacarias,

On Fri, 05 Jul 2013 09:57:14 -0300, Gustavo Zacarias wrote:
> On 07/05/2013 05:40 AM, Thomas Petazzoni wrote:
> 
> > When converting gcc to the package infrastructure, a specific thing
> > for PowerPC was forgotten: applying the conditional patch
> > powerpc-link-with-math-lib.patch.conditional. This breaks the build of
> > some PowerPC toolchains, with failures such as:
> > 
> > <http://jenkins.free-electrons.com/job/buildroot/./config=qemu_ppc_virtex_ml507_defconfig/ws/output/host/usr/lib/gcc/powerpc-buildroot-linux-uclibc/4.7.3/../../../../powerpc-buildroot-linux-uclibc/lib/libgcc_s.so.1>: undefined reference to `copysignl'
> > 
> > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> 
> Acked-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
> Tested-by: Gustavo Zacarias <gustavo@zacarias.com.ar>

Thanks :)

> > Anyone knows why we have this conditional patch? Can't it be made a
> > normal patch, with the appropriate modifications? Why isn't that
> > upstream since all those years?
> 
> http://gcc.gnu.org/ml/gcc-patches/2008-10/msg00292.html for the
> history/thread.

I remember reading this thread a long time ago. But my question is
more: why hasn't the problem been fixed since 5 years? :-)

> A sample failing config without the patch is
> qemu_ppc_virtex_ml507_defconfig (a powerpc 440 core, soft float).

Indeed, that's the one that was failing in our Jenkins builds, as can be
seen from the URL above.

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2013-07-05 13:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-05  8:40 [Buildroot] [PATCH] gcc: apply PowerPC patch when needed Thomas Petazzoni
2013-07-05 12:57 ` Gustavo Zacarias
2013-07-05 13:01   ` Thomas Petazzoni [this message]
2013-07-05 13:16     ` Gustavo Zacarias
2013-07-05 13:31 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130705150137.773e3ad7@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.