From: Theodore Ts'o <tytso@mit.edu>
To: "Lukáš Czerner" <lczerner@redhat.com>
Cc: Jan Kara <jack@suse.cz>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: Silence warning in ext4_writepages()
Date: Fri, 5 Jul 2013 21:58:32 -0400 [thread overview]
Message-ID: <20130706015832.GA32062@thunk.org> (raw)
In-Reply-To: <alpine.LFD.2.00.1307031204000.3892@localhost.localdomain>
On Wed, Jul 03, 2013 at 12:07:25PM +0200, Lukáš Czerner wrote:
> On Tue, 2 Jul 2013, Jan Kara wrote:
>
> > Date: Tue, 2 Jul 2013 20:14:29 +0200
> > From: Jan Kara <jack@suse.cz>
> > To: Ted Tso <tytso@mit.edu>
> > Cc: linux-ext4@vger.kernel.org, Jan Kara <jack@suse.cz>
> > Subject: [PATCH] ext4: Silence warning in ext4_writepages()
> >
> > The loop in mpage_map_and_submit_extent() is guaranteed to always run at
> > least once since the caller of mpage_map_and_submit_extent() makes sure
> > map->m_len > 0. So make that explicit using do-while instead of pure
> > while which also silences the compiler warning about uninitialized 'err'
> > variable.
>
> Looks good.
>
> Reviewed-by: Lukas Czerner <lczerner@redhat.com>
Applied, thanks.
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2013-07-06 1:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-02 18:14 [PATCH] ext4: Silence warning in ext4_writepages() Jan Kara
2013-07-03 10:07 ` Lukáš Czerner
2013-07-06 1:58 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130706015832.GA32062@thunk.org \
--to=tytso@mit.edu \
--cc=jack@suse.cz \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.