All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Rajesh Borundia <rajesh.borundia@qlogic.com>,
	Shahed Shaikh <shahed.shaikh@qlogic.com>,
	Jitendra Kalsaria <jitendra.kalsaria@qlogic.com>,
	Sony Chacko <sony.chacko@qlogic.com>,
	linux-driver@qlogic.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: qlcnic binary sysfs file abuse
Date: Sat, 6 Jul 2013 17:29:49 -0700	[thread overview]
Message-ID: <20130707002949.GA15822@kroah.com> (raw)

Hi all,

I was doing a kernel-wide audit on all of the binary sysfs files, and
noticed a metric ton of them in the qlcnic driver.

The rules about binary sysfs files are that they can not be touched by
the kernel at all, they are "pass-through" directly to the hardware, and
it seems that this driver is not doing that properly.

It also seems that almost all of these files are merely "debugging"
files, but as I can't seem to find the relevant Documentation/ABI/
documentation for them, I can't be sure.

So, any objection to me just deleting these entirely?  Or, if they
really are needed, can I just move them to debugfs, which is where I
think they should have been from the beginning?

Oh, and I'm pretty sure that the creation of these is totally racy, so I
really doubt that anyone is using them otherwise they would have noticed
this already.

thanks,

greg k-h

             reply	other threads:[~2013-07-07  0:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-07  0:29 Greg KH [this message]
2013-07-25 19:37 ` qlcnic binary sysfs file abuse Sony Chacko
2013-07-25 20:08   ` Greg KH
2013-07-25 21:09   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130707002949.GA15822@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=jitendra.kalsaria@qlogic.com \
    --cc=linux-driver@qlogic.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rajesh.borundia@qlogic.com \
    --cc=shahed.shaikh@qlogic.com \
    --cc=sony.chacko@qlogic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.