From: Jonathan Nieder <jrnieder@gmail.com>
To: Kyle McKay <mackyle@gmail.com>
Cc: David Rothenberger <daveroth@acm.org>,
git@vger.kernel.org, users@subversion.apache.org
Subject: Re: [PATCH 0/2] allow git-svn fetching to work using serf
Date: Sun, 7 Jul 2013 10:40:43 -0700 [thread overview]
Message-ID: <20130707174043.GA9975@google.com> (raw)
In-Reply-To: <FBCA37F9-4988-4773-8D8D-9CB041C35289@gmail.com>
(cc-ing subversion's users@ list for advice)
Kyle McKay wrote:
> On Jul 6, 2013, at 18:37, Jonathan Nieder wrote:
>> Kyle McKay wrote:
>>> Begin forwarded message:
>>>> [2] http://subversion.tigris.org/issues/show_bug.cgi?id=2932
>>
>> Ah, thanks for the context.
>>
>> It's still not clear to me how we know that ra_serf driving the editor
>> in a non depth-first manner is the problem here. Has that explanation
>> been confirmed somehow?
[...]
> Since ra_serf makes multiple connections to the server (hard-coded
> to 4 prior to svn 1.8, defaults to 4 in svn 1.8 but can be set to
> between 1 and 8) it makes sense there would be multiple active calls
> to apply_textdelta if processing is done as results are received on
> the multiple connections.
Ah, that's worrisome. Do I understand you correctly that to work with
ra_serf in skelta mode, callers need to make their apply_textdelta
callback thread-safe?
Or do you just mean that the traversal order is based on the order in
which results are received? That would be fine, as long as after each
apply_textdelta call, close_file is called before the next
apply_textdelta.
Jonathan
next prev parent reply other threads:[~2013-07-07 17:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-06 3:41 [PATCH 0/2] allow git-svn fetching to work using serf Kyle McKay
2013-07-06 7:17 ` David Rothenberger
2013-07-07 0:28 ` Jonathan Nieder
2013-07-07 1:24 ` Kyle McKay
2013-07-07 1:37 ` Jonathan Nieder
2013-07-07 2:46 ` Kyle McKay
2013-07-07 17:40 ` Jonathan Nieder [this message]
2013-07-07 3:44 ` David Rothenberger
2013-07-07 17:53 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130707174043.GA9975@google.com \
--to=jrnieder@gmail.com \
--cc=daveroth@acm.org \
--cc=git@vger.kernel.org \
--cc=mackyle@gmail.com \
--cc=users@subversion.apache.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.