From: John Keeping <john@keeping.me.uk>
To: Robin Rosenberg <robin.rosenberg@dewire.com>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] Documentation: finding $(prefix)/etc/gitconfig when prefix = /usr
Date: Sun, 7 Jul 2013 23:21:52 +0100 [thread overview]
Message-ID: <20130707222152.GV9161@serenity.lan> (raw)
In-Reply-To: <1373234402-6856-1-git-send-email-robin.rosenberg@dewire.com>
On Mon, Jul 08, 2013 at 12:00:02AM +0200, Robin Rosenberg wrote:
> Signed-off-by: Robin Rosenberg <robin.rosenberg@dewire.com>
> ---
> Documentation/git-config.txt | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/git-config.txt b/Documentation/git-config.txt
> index 9ae2508..3198d52 100644
> --- a/Documentation/git-config.txt
> +++ b/Documentation/git-config.txt
> @@ -107,7 +107,8 @@ See also <<FILES>>.
>
> --system::
> For writing options: write to system-wide $(prefix)/etc/gitconfig
> - rather than the repository .git/config.
> + rather than the repository .git/config. However, $(prefix) is /usr
> + then /etc/gitconfig is used.
That's a build time condition, not something that's decided at runtime
so I'm not sure that this logic belongs in the user facing
documentation. The technically correct change would be to use
"$(sysconfdir)/gitconfig" but I think that will just confuse users more.
Since we have a build step for the documentation, I wonder if it's
possible to replace these with the correct directory at build time.
> +
> For reading options: read only from system-wide $(prefix)/etc/gitconfig
> rather than from all available files.
> @@ -214,7 +215,8 @@ $XDG_CONFIG_HOME/git/config::
> file was added fairly recently.
>
> $(prefix)/etc/gitconfig::
> - System-wide configuration file.
> + System-wide configuration file, unless $(prefix) is /usr. In the
> + latter case /etc/gitconfig is used.
>
> If no further options are given, all reading options will read all of these
> files that are available. If the global or the system-wide configuration
> --
> 1.8.3.rc0.19.g7e6a0cc
next prev parent reply other threads:[~2013-07-07 22:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-07 22:00 [PATCH] Documentation: finding $(prefix)/etc/gitconfig when prefix = /usr Robin Rosenberg
2013-07-07 22:21 ` John Keeping [this message]
2013-07-07 22:32 ` Robin Rosenberg
2013-07-07 22:23 ` Robin Rosenberg
2013-07-07 22:47 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130707222152.GV9161@serenity.lan \
--to=john@keeping.me.uk \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=robin.rosenberg@dewire.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.