From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Alexey Perevalov <a.perevalov@samsung.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 2/2] extensions: libxt_dccp/libxt_sctp: enable debug tracing by DEBUG define
Date: Mon, 8 Jul 2013 04:55:10 +0200 [thread overview]
Message-ID: <20130708025510.GA14195@localhost> (raw)
In-Reply-To: <1372922778-12997-3-git-send-email-a.perevalov@samsung.com>
On Thu, Jul 04, 2013 at 11:26:18AM +0400, Alexey Perevalov wrote:
> Signed-off-by: Alexey Perevalov <a.perevalov@samsung.com>
> ---
> extensions/libxt_dccp.c | 4 ++--
> extensions/libxt_sctp.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/extensions/libxt_dccp.c b/extensions/libxt_dccp.c
> index a35cabb..06cd23d 100644
> --- a/extensions/libxt_dccp.c
> +++ b/extensions/libxt_dccp.c
> @@ -16,11 +16,11 @@
> #include <linux/netfilter/x_tables.h>
> #include <linux/netfilter/xt_dccp.h>
>
> -#if 0
> +#ifdef DEBUG
> #define DEBUGP(format, first...) printf(format, ##first)
> #define static
> #else
> -#define DEBUGP(format, fist...)
> +#define DEBUGP(format, fist...)
> #endif
I don't find any client of this code for libxt_dccp, better delete it
in that case.
> enum {
> diff --git a/extensions/libxt_sctp.c b/extensions/libxt_sctp.c
> index 56a4cdf..f5959cb 100644
> --- a/extensions/libxt_sctp.c
> +++ b/extensions/libxt_sctp.c
> @@ -20,11 +20,11 @@
>
> #include <linux/netfilter/xt_sctp.h>
>
> -#if 0
> +#if DEBUG
> #define DEBUGP(format, first...) printf(format, ##first)
> #define static
> #else
> -#define DEBUGP(format, fist...)
> +#define DEBUGP(format, fist...)
> #endif
>
> static void
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2013-07-08 2:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-04 7:26 [PATCH 0/2] minor debugging fixes Alexey Perevalov
2013-07-04 7:26 ` [PATCH 1/2] Clarify DEBUG usage macro Alexey Perevalov
2013-07-04 7:26 ` [PATCH 2/2] extensions: libxt_dccp/libxt_sctp: enable debug tracing by DEBUG define Alexey Perevalov
2013-07-08 2:55 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130708025510.GA14195@localhost \
--to=pablo@netfilter.org \
--cc=a.perevalov@samsung.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.