From: Phil Oester <kernel@linuxace.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org, zenczykowski@gmail.com
Subject: Re: [PATCH v2] iptables: Sort table names in ip[6]tables-save
Date: Sun, 7 Jul 2013 21:21:46 -0700 [thread overview]
Message-ID: <20130708042146.GB5532@linuxace.com> (raw)
In-Reply-To: <20130708023919.GA14122@localhost>
On Mon, Jul 08, 2013 at 04:39:19AM +0200, Pablo Neira Ayuso wrote:
> On Wed, Jul 03, 2013 at 12:29:12AM -0400, Phil Oester wrote:
> > Depending upon the load order of rules, the output from ip[6]tables-save
> > will vary, as ip[6]_tables_names is sorted LIFO. As reported by
> > Linus van Geuns, this makes comparing output from ip[6]tables-save across
> > reboots difficult. Fix this by sorting table names prior to walking
> > the tables, making output consistent.
>
> Better add an option to explicitly request the sorting, so we stick to
> the old behaviour by default.
The old behavior is random depending upon module load order. We should
keep random behavior?
> But, how can the unsorted table output be useful?
Ask Maciej - he is the one that requested this be provided as an option.
Phil
prev parent reply other threads:[~2013-07-08 4:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-03 4:29 [PATCH v2] iptables: Sort table names in ip[6]tables-save Phil Oester
2013-07-08 2:39 ` Pablo Neira Ayuso
2013-07-08 4:21 ` Phil Oester [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130708042146.GB5532@linuxace.com \
--to=kernel@linuxace.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=zenczykowski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.