From: Tony Lindgren <tony@atomide.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@infradead.org,
arm@kernel.org
Subject: Re: [PATCH 4/8] ARM: OMAP: build mach-omap code only if needed
Date: Mon, 8 Jul 2013 05:00:48 -0700 [thread overview]
Message-ID: <20130708120048.GW5523@atomide.com> (raw)
In-Reply-To: <1373041417-217728-5-git-send-email-arnd@arndb.de>
* Arnd Bergmann <arnd@arndb.de> [130705 09:28]:
> If we build a kernel with CONFIG_ARCH_OMAP2PLUS enabled but all of the
> individual SoCs disabled, we run into a large number of link errors
> because if incorrect dependencies:
>
> arch/arm/mach-omap2/built-in.o: In function `_add_initiator_dep':
> arch/arm/mach-omap2/omap_hwmod.c:691: undefined reference to `clkdm_add_sleepdep' arch/arm/mach-omap2/built-in.o: In function `_del_initiator_dep':
> arch/arm/mach-omap2/omap_hwmod.c:720: undefined reference to `clkdm_del_sleepdep' arch/arm/mach-omap2/built-in.o: In function `_enable':
> arch/arm/mach-omap2/omap_hwmod.c:2145: undefined reference to `clkdm_in_hwsup'
> arch/arm/mach-omap2/omap_hwmod.c:2147: undefined reference to `clkdm_hwmod_enable'
> arch/arm/mach-omap2/omap_hwmod.c:2191: undefined reference to `clkdm_hwmod_disable'
> arch/arm/mach-omap2/omap_hwmod.c:2146: undefined reference to `clkdm_missing_idle_reporting' arch/arm/mach-omap2/built-in.o: In function `_idle':
> arch/arm/mach-omap2/omap_hwmod.c:2235: undefined reference to `clkdm_hwmod_disable' arch/arm/mach-omap2/built-in.o: In function `_shutdown':
> arch/arm/mach-omap2/omap_hwmod.c:2338: undefined reference to `clkdm_hwmod_disable' arch/arm/mach-omap2/built-in.o: In function `omap_hwmod_get_context_loss_count':
> arch/arm/mach-omap2/omap_hwmod.c:4071: undefined reference to `pwrdm_get_context_loss_count' arch/arm/mach-omap2/built-in.o: In function `omap_pm_clkdms_setup':
> arch/arm/mach-omap2/pm.c:114: undefined reference to `clkdm_allow_idle'
> arch/arm/mach-omap2/pm.c:117: undefined reference to `clkdm_sleep' arch/arm/mach-omap2/built-in.o: In function `omap2_common_pm_late_init':
> arch/arm/mach-omap2/pm.c:294: undefined reference to `omap_voltage_late_init' arch/arm/mach-omap2/built-in.o: In function `omap2_gpio_dev_init':
> arch/arm/mach-omap2/gpio.c:133: undefined reference to `pwrdm_can_ever_lose_context'
>
> We can avoid this if we make CONFIG_ARCH_OMAP2PLUS a silent option that
> gets enabled any time that one of the SoC versions is enabled.
>
> Cc: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Sounds like there's some issue as noted by Olof, but the
patch is good in general:
Acked-by: Tony Lindgren <tony@atomide.com>
next prev parent reply other threads:[~2013-07-08 12:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-05 16:23 [PATCH 0/8] ARM: SoC specific bug fixes Arnd Bergmann
2013-07-05 16:23 ` [PATCH 1/8] clocksource: armada-xp: always register local_timer_ops Arnd Bergmann
2013-07-05 16:33 ` Gregory CLEMENT
2013-07-05 16:57 ` Stephen Boyd
2013-07-05 16:23 ` [PATCH 2/8] ARM: omap5: omap5 has SCU and TWD Arnd Bergmann
2013-07-08 12:03 ` Tony Lindgren
2013-07-05 16:23 ` [PATCH 3/8] ARM: zynq: use DT_MACHINE_START Arnd Bergmann
2013-07-08 6:18 ` Michal Simek
2013-07-05 16:23 ` [PATCH 4/8] ARM: OMAP: build mach-omap code only if needed Arnd Bergmann
2013-07-08 11:31 ` Olof Johansson
2013-07-08 11:34 ` Olof Johansson
2013-07-08 11:34 ` Olof Johansson
2013-07-08 12:00 ` Tony Lindgren [this message]
2013-07-05 16:23 ` [PATCH 5/8] ARM: sti: move DEBUG_STI_UART into alphabetical order Arnd Bergmann
2013-07-05 16:23 ` [PATCH 6/8] ARM: OMAP: omap_common_late_init may be unused Arnd Bergmann
2013-07-08 12:01 ` Tony Lindgren
2013-07-05 16:23 ` [PATCH 7/8] ARM: ixp4xx: avoid circular header dependency Arnd Bergmann
2013-07-06 18:11 ` Krzysztof Halasa
2013-07-05 16:23 ` [PATCH 8/8] ARM: exynos: select PM_GENERIC_DOMAINS only when used Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130708120048.GW5523@atomide.com \
--to=tony@atomide.com \
--cc=arm@kernel.org \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.