All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luiz Capitulino <lcapitulino@redhat.com>
To: Seiji Aguchi <seiji.aguchi@hds.com>
Cc: "kwolf@redhat.com" <kwolf@redhat.com>,
	"aliguori@us.ibm.com" <aliguori@us.ibm.com>,
	"stefanha@gmail.com" <stefanha@gmail.com>,
	"mtosatti@redhat.com" <mtosatti@redhat.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"armbru@redhat.com" <armbru@redhat.com>,
	"dle-develop@lists.sourceforge.net"
	<dle-develop@lists.sourceforge.net>,
	Tomoki Sekiyama <tomoki.sekiyama@hds.com>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>,
	"lersek@redhat.com" <lersek@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v6] add timestamp to error_report()
Date: Mon, 8 Jul 2013 15:00:12 -0400	[thread overview]
Message-ID: <20130708150012.748e2cd5@redhat.com> (raw)
In-Reply-To: <A5ED84D3BB3A384992CBB9C77DEDA4D443E1B1A6@USINDEM103.corp.hds.com>

On Mon, 8 Jul 2013 18:47:24 +0000
Seiji Aguchi <seiji.aguchi@hds.com> wrote:

> > > +DEF("msg", HAS_ARG, QEMU_OPTION_msg,
> > > +    "-msg timestamp[=on|off]\n"
> > > +    "                change the format of messages\n"
> > > +    "                on|off controls leading timestamps (default:on)\n",
> > 
> > Did you really intend to say it's on by default? Because it's actually
> > disabled by default. I prefer having this disabled btw, and I can fix it
> > myself before applying if that's what you intended.
> 
> 
> My default  is "-msg timestamp".
> Why do you think it is actually disabled by default?

Oh, for some reason I assumed you wanted the timestamps to show up
even when -msg is not passed. But now I see that it's on by default
only if -msg timestamp is passed. Seems reasonable.

Applied to the qmp branch, thanks.

  reply	other threads:[~2013-07-08 19:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-04  3:02 [Qemu-devel] [PATCH v6] add timestamp to error_report() Seiji Aguchi
2013-07-04  8:58 ` Stefan Hajnoczi
2013-07-08 18:17 ` Luiz Capitulino
2013-07-08 18:47   ` Seiji Aguchi
2013-07-08 19:00     ` Luiz Capitulino [this message]
2013-07-09  7:42       ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130708150012.748e2cd5@redhat.com \
    --to=lcapitulino@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=armbru@redhat.com \
    --cc=dle-develop@lists.sourceforge.net \
    --cc=kwolf@redhat.com \
    --cc=lersek@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=seiji.aguchi@hds.com \
    --cc=stefanha@gmail.com \
    --cc=tomoki.sekiyama@hds.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.