From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48125) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwY1A-0003FA-9a for qemu-devel@nongnu.org; Tue, 09 Jul 2013 09:31:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UwY17-0001Wo-D6 for qemu-devel@nongnu.org; Tue, 09 Jul 2013 09:31:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49967) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwY17-0001WY-4l for qemu-devel@nongnu.org; Tue, 09 Jul 2013 09:31:41 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r69DVdKT019236 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 9 Jul 2013 09:31:40 -0400 Date: Tue, 9 Jul 2013 09:31:38 -0400 From: Luiz Capitulino Message-ID: <20130709093138.5c319b47@redhat.com> In-Reply-To: <1373357135-9294-1-git-send-email-kwolf@redhat.com> References: <1373357135-9294-1-git-send-email-kwolf@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qapi-schema: Use existing type for drive-backup arguments List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org On Tue, 9 Jul 2013 10:05:35 +0200 Kevin Wolf wrote: > This removes duplicated definitions and documentation by reusing the > existing data type. > > Signed-off-by: Kevin Wolf Applied to the qmp branch, thanks. > --- > > To be applied on top of '[PATCH v3 0/3] qapi: Top-level type reference for > command definitions' > > qapi-schema.json | 32 ++------------------------------ > 1 file changed, 2 insertions(+), 30 deletions(-) > > diff --git a/qapi-schema.json b/qapi-schema.json > index a90aeb1..b251d28 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -1791,42 +1791,14 @@ > # The operation can be stopped before it has completed using the > # block-job-cancel command. > # > -# @device: the name of the device which should be copied. > -# > -# @target: the target of the new image. If the file exists, or if it > -# is a device, the existing file/device will be used as the new > -# destination. If it does not exist, a new file will be created. > -# > -# @format: #optional the format of the new destination, default is to > -# probe if @mode is 'existing', else the format of the source > -# > -# @mode: #optional whether and how QEMU should create a new image, default is > -# 'absolute-paths'. > -# > -# @speed: #optional the maximum speed, in bytes per second > -# > -# @on-source-error: #optional the action to take on an error on the source, > -# default 'report'. 'stop' and 'enospc' can only be used > -# if the block device supports io-status (see BlockInfo). > -# > -# @on-target-error: #optional the action to take on an error on the target, > -# default 'report' (no limitations, since this applies to > -# a different block device than @device). > -# > -# Note that @on-source-error and @on-target-error only affect background I/O. > -# If an error occurs during a guest write request, the device's rerror/werror > -# actions will be used. > +# For the arguments, see the documentation of DriveBackup. > # > # Returns: nothing on success > # If @device is not a valid block device, DeviceNotFound > # > # Since 1.6 > ## > -{ 'command': 'drive-backup', > - 'data': { 'device': 'str', 'target': 'str', '*format': 'str', > - '*mode': 'NewImageMode', '*speed': 'int', > - '*on-source-error': 'BlockdevOnError', > - '*on-target-error': 'BlockdevOnError' } } > +{ 'command': 'drive-backup', 'data': 'DriveBackup' } > > ## > # @drive-mirror