From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35968)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1UwYhz-0001e4-Dj
	for qemu-devel@nongnu.org; Tue, 09 Jul 2013 10:16:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1UwYhu-0001JR-P2
	for qemu-devel@nongnu.org; Tue, 09 Jul 2013 10:15:59 -0400
Received: from mx1.redhat.com ([209.132.183.28]:17846)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1UwYht-0001J7-RL
	for qemu-devel@nongnu.org; Tue, 09 Jul 2013 10:15:54 -0400
Date: Tue, 9 Jul 2013 10:14:39 -0400
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20130709101439.4e1d45b3@redhat.com>
In-Reply-To: <51DC183E.4020409@linux.vnet.ibm.com>
References: <1372477981-7512-1-git-send-email-xiawenc@linux.vnet.ibm.com>
	<1372477981-7512-2-git-send-email-xiawenc@linux.vnet.ibm.com>
	<20130708111711.0b2631d6@redhat.com>
	<51DB7040.8020306@linux.vnet.ibm.com>
	<51DC183E.4020409@linux.vnet.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH V5 1/7] monitor: avoid direct use of global
 *cur_mon in completion functions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com

On Tue, 09 Jul 2013 22:03:42 +0800
Wenchao Xia <xiawenc@linux.vnet.ibm.com> wrote:

> 
> >> You could pass cur_mon to readline_completion() in readline_handle_byte()
> >> to avoid all this, but it would be preferable to clarify the matter.
> >>
> >> This is also another benefit of having readline_completion() in a
> >> different patch, you can (and should!) clarify this point in the commit
> >> log along with testing results.
> >>
> >    OK, I'll test multiple monitors case.
> >
> >
> >
>    Do you have an example about how invoke qemu with multiple monitor?
> Do you have recommendation about the way to connect to qemu's moniotr?
> I tried pty with minicom but it seems not good, so wonder your method.

You can open telnet sessions:

 -monitor tcp:0:4444,server,nowait,telnet \
 -monitor tcp:0:4445,server,nowait,telnet

But note that, besides testing, I'd like to see an explanation on
the commitlog as to why dropping cur_mon doesn't brake the current
code.