From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 09/12] ARM: DRA7: hwmod: Create initial DRA7XX SoC data Date: Tue, 9 Jul 2013 04:36:57 -0700 Message-ID: <20130709113657.GF5523@atomide.com> References: <1373355139-12487-1-git-send-email-rnayak@ti.com> <1373355139-12487-10-git-send-email-rnayak@ti.com> <20130709083152.GC5523@atomide.com> <51DBE2A2.2040403@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-03-ewr.mailhop.org ([204.13.248.66]:15099 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752846Ab3GILhA (ORCPT ); Tue, 9 Jul 2013 07:37:00 -0400 Content-Disposition: inline In-Reply-To: <51DBE2A2.2040403@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Rajendra Nayak Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, paul@pwsan.com, khilman@linaro.org, benoit.cousson@gmail.com, r.sricharan@ti.com, ambresh@ti.com, Tero Kristo * Rajendra Nayak [130709 03:21]: > On Tuesday 09 July 2013 02:01 PM, Tony Lindgren wrote: > > * Rajendra Nayak [130709 00:39]: > >> From: Ambresh K > > > >> --- /dev/null > >> +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c > > ... > > > >> +/* dma_system */ > >> +static struct omap_hwmod_irq_info dra7xx_dma_system_irqs[] = { > >> + { .name = "0", .irq = 12 + DRA7XX_IRQ_GIC_START }, > >> + { .name = "1", .irq = 13 + DRA7XX_IRQ_GIC_START }, > >> + { .name = "2", .irq = 14 + DRA7XX_IRQ_GIC_START }, > >> + { .name = "3", .irq = 15 + DRA7XX_IRQ_GIC_START }, > >> + { .irq = -1 } > >> +}; > > > > I think these should no longer be needed? > > These are needed only for dma because mach-omap2/dma.c still creates > devices from hmwod and which are used by plat/dma.c. > These irqs for sdma exist even in the cleaned up omap4 and omap5 hmwod files. > I'll try and get rid of that dependency of plat/dma on mach/dma to create devices. OK great. > > In general, we must move the hwmod stuff to drivers/bus and start > > parsing the data from device tree along the lines Tero is doing > > for the clock data. > > We already have irq/dma and iospace moved to DT (some iospace info still > exists because of non-DT drivers). With Teros patches to move clock data we > should be able to pass the main_clk and all interface level clock info too > from DT. OK. Tony From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Tue, 9 Jul 2013 04:36:57 -0700 Subject: [PATCH 09/12] ARM: DRA7: hwmod: Create initial DRA7XX SoC data In-Reply-To: <51DBE2A2.2040403@ti.com> References: <1373355139-12487-1-git-send-email-rnayak@ti.com> <1373355139-12487-10-git-send-email-rnayak@ti.com> <20130709083152.GC5523@atomide.com> <51DBE2A2.2040403@ti.com> Message-ID: <20130709113657.GF5523@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Rajendra Nayak [130709 03:21]: > On Tuesday 09 July 2013 02:01 PM, Tony Lindgren wrote: > > * Rajendra Nayak [130709 00:39]: > >> From: Ambresh K > > > >> --- /dev/null > >> +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c > > ... > > > >> +/* dma_system */ > >> +static struct omap_hwmod_irq_info dra7xx_dma_system_irqs[] = { > >> + { .name = "0", .irq = 12 + DRA7XX_IRQ_GIC_START }, > >> + { .name = "1", .irq = 13 + DRA7XX_IRQ_GIC_START }, > >> + { .name = "2", .irq = 14 + DRA7XX_IRQ_GIC_START }, > >> + { .name = "3", .irq = 15 + DRA7XX_IRQ_GIC_START }, > >> + { .irq = -1 } > >> +}; > > > > I think these should no longer be needed? > > These are needed only for dma because mach-omap2/dma.c still creates > devices from hmwod and which are used by plat/dma.c. > These irqs for sdma exist even in the cleaned up omap4 and omap5 hmwod files. > I'll try and get rid of that dependency of plat/dma on mach/dma to create devices. OK great. > > In general, we must move the hwmod stuff to drivers/bus and start > > parsing the data from device tree along the lines Tero is doing > > for the clock data. > > We already have irq/dma and iospace moved to DT (some iospace info still > exists because of non-DT drivers). With Teros patches to move clock data we > should be able to pass the main_clk and all interface level clock info too > from DT. OK. Tony