From: Denys Dmytriyenko <denys@ti.com>
To: "Cooper Jr., Franklin" <fcooper@ti.com>
Cc: "meta-ti@yoctoproject.org" <meta-ti@yoctoproject.org>
Subject: Re: [master & danny][PATCH 2/2] u-boot: Add memory alignment fix for armv7 for am37x and am3517
Date: Tue, 9 Jul 2013 15:07:56 -0400 [thread overview]
Message-ID: <20130709190756.GO14185@edge> (raw)
In-Reply-To: <8F29D6B095ED194EA1980491A5E029710C4F177C@DFLE08.ent.ti.com>
On Tue, Jul 09, 2013 at 03:04:57PM -0400, Cooper Jr., Franklin wrote:
>
>
> > -----Original Message-----
> > From: Dmytriyenko, Denys
> > Sent: Tuesday, July 09, 2013 11:54 AM
> > To: Maupin, Chase
> > Cc: Cooper Jr., Franklin; meta-ti@yoctoproject.org
> > Subject: Re: [meta-ti] [master & danny][PATCH 2/2] u-boot: Add memory
> > alignment fix for armv7 for am37x and am3517
> >
> > On Tue, Jul 02, 2013 at 07:09:54PM +0000, Maupin, Chase wrote:
> > > Couldn't you only use one copy of the patch file and place it in a
> > > more generic directory? Not a big issue but just asking.
> >
> > Franklin,
> >
> > Any comment for the above question?
> Sent a v2 addressing Chase's comment.
Thanks!
> > Also, please remind me in 2 days to apply your patches. I'm not sure I will have
> > time today or tomorrow. Thanks.
> Will do!
> >
> > --
> > Denys
> >
> >
> > > >-----Original Message-----
> > > >From: meta-ti-bounces@yoctoproject.org [mailto:meta-ti-
> > > >bounces@yoctoproject.org] On Behalf Of Cooper Jr., Franklin
> > > >Sent: Tuesday, July 02, 2013 11:48 AM
> > > >To: meta-ti@yoctoproject.org
> > > >Subject: [meta-ti] [master & danny][PATCH 2/2] u-boot: Add memory
> > > >alignment fix for armv7 for am37x and am3517
> > > >
> > > >* On am335x a memory alignment issue was found when using the
> > > >Linaro toolchain.
> > > >* A similar patch was applied for am335x that fixed this well
> > > >documented issue.
> > > >* Add a similar fix to am37x and am3517 since this is a generic
> > > >armv7 issue.
> > > >
> > > >Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
> > > >---
> > > > .../0001-armv7-Unaligned-access-fix.patch | 30
> > > >++++++++++++++++++++
> > > > recipes-bsp/u-boot/u-boot-am3517_2011.09.bb | 5 ++-
> > > > .../0001-armv7-Unaligned-access-fix.patch | 30
> > > >++++++++++++++++++++
> > > > recipes-bsp/u-boot/u-boot-am37x_2012.04.01.bb | 3 ++
> > > > 4 files changed, 66 insertions(+), 2 deletions(-)
> > > > create mode 100644 recipes-bsp/u-boot/u-boot-am3517-2011.09/0001-
> > > >armv7-Unaligned-access-fix.patch
> > > > create mode 100644 recipes-bsp/u-boot/u-boot-am37x-
> > > >2012.04.01/0001-armv7-Unaligned-access-fix.patch
> > > >
> > > >diff --git a/recipes-bsp/u-boot/u-boot-am3517-2011.09/0001-armv7-
> > > >Unaligned-access-fix.patch b/recipes-bsp/u-boot/u-boot-am3517-
> > > >2011.09/0001-armv7-Unaligned-access-fix.patch
> > > >new file mode 100644
> > > >index 0000000..35307ac
> > > >--- /dev/null
> > > >+++ b/recipes-bsp/u-boot/u-boot-am3517-2011.09/0001-armv7-
> > > >Unaligned-access-fix.patch
> > > >@@ -0,0 +1,30 @@
> > > >+From 40f1e7db785f477a2aa145a3b47bd498c48ad52d Mon Sep 17
> > 00:00:00
> > > >2001
> > > >+From: Steve Kipisz <s-kipisz2@ti.com>
> > > >+Date: Fri, 14 Jun 2013 05:16:52 -0500
> > > >+Subject: [PATCH] armv7:Unaligned access fix
> > > >+
> > > >+This fixes an unaligned access data abort introduced when using
> > > >gcc 4.7
> > > >+or higher. The Linaro toolchain uses gcc 4.7.3. This is
> > > >documented in u-boot
> > > >+doc/README.arm-unaligned-accesses.
> > > >+
> > > >+Signed-off-by: Steve Kipisz <s-kipisz2@ti.com>
> > > >+---
> > > >+ arch/arm/cpu/armv7/config.mk | 2 +-
> > > >+ 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >+
> > > >+diff --git a/arch/arm/cpu/armv7/config.mk
> > > >b/arch/arm/cpu/armv7/config.mk
> > > >+index 9c3e2f3..9736da8 100644
> > > >+--- a/arch/arm/cpu/armv7/config.mk
> > > >++++ b/arch/arm/cpu/armv7/config.mk
> > > >+@@ -20,7 +20,7 @@
> > > >+ # Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> > > >+ # MA 02111-1307 USA
> > > >+ #
> > > >+-PLATFORM_RELFLAGS += -fno-common -ffixed-r8 -msoft-float
> > > >++PLATFORM_RELFLAGS += -fno-common -ffixed-r8 -msoft-float -mno-
> > > >unaligned-access
> > > >+
> > > >+ # If armv7-a is not supported by GCC fall-back to armv5, which
> > > >is
> > > >+ # supported by more tool-chains
> > > >+--
> > > >+1.7.9.5
> > > >+
> > > >diff --git a/recipes-bsp/u-boot/u-boot-am3517_2011.09.bb
> > > >b/recipes-bsp/u-boot/u-boot-am3517_2011.09.bb
> > > >index 6321406..02019e9 100644
> > > >--- a/recipes-bsp/u-boot/u-boot-am3517_2011.09.bb
> > > >+++ b/recipes-bsp/u-boot/u-boot-am3517_2011.09.bb
> > > >@@ -6,9 +6,10 @@ COMPATIBLE_MACHINE = "omap3"
> > > >
> > > > DEFAULT_PREFERENCE = "-1"
> > > >
> > > >-PR = "r0+gitr${SRCPV}"
> > > >+PR = "r1+gitr${SRCPV}"
> > > >
> > > >-SRC_URI = "git://arago-project.org/git/projects/u-boot-
> > > >am33x.git;protocol=git;branch=${BRANCH}"
> > > >+SRC_URI = "git://arago-project.org/git/projects/u-boot-
> > > >am33x.git;protocol=git;branch=${BRANCH} \
> > > >+ file://0001-armv7-Unaligned-access-fix.patch"
> > > >
> > > > BRANCH = "AM335XPSP_04.06.00.08"
> > > >
> > > >diff --git a/recipes-bsp/u-boot/u-boot-am37x-2012.04.01/0001-
> > > >armv7-Unaligned-access-fix.patch b/recipes-bsp/u-boot/u-boot-
> > > >am37x-2012.04.01/0001-armv7-Unaligned-access-fix.patch
> > > >new file mode 100644
> > > >index 0000000..35307ac
> > > >--- /dev/null
> > > >+++ b/recipes-bsp/u-boot/u-boot-am37x-2012.04.01/0001-armv7-
> > > >Unaligned-access-fix.patch
> > > >@@ -0,0 +1,30 @@
> > > >+From 40f1e7db785f477a2aa145a3b47bd498c48ad52d Mon Sep 17
> > 00:00:00
> > > >2001
> > > >+From: Steve Kipisz <s-kipisz2@ti.com>
> > > >+Date: Fri, 14 Jun 2013 05:16:52 -0500
> > > >+Subject: [PATCH] armv7:Unaligned access fix
> > > >+
> > > >+This fixes an unaligned access data abort introduced when using
> > > >gcc 4.7
> > > >+or higher. The Linaro toolchain uses gcc 4.7.3. This is
> > > >documented in u-boot
> > > >+doc/README.arm-unaligned-accesses.
> > > >+
> > > >+Signed-off-by: Steve Kipisz <s-kipisz2@ti.com>
> > > >+---
> > > >+ arch/arm/cpu/armv7/config.mk | 2 +-
> > > >+ 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >+
> > > >+diff --git a/arch/arm/cpu/armv7/config.mk
> > > >b/arch/arm/cpu/armv7/config.mk
> > > >+index 9c3e2f3..9736da8 100644
> > > >+--- a/arch/arm/cpu/armv7/config.mk
> > > >++++ b/arch/arm/cpu/armv7/config.mk
> > > >+@@ -20,7 +20,7 @@
> > > >+ # Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> > > >+ # MA 02111-1307 USA
> > > >+ #
> > > >+-PLATFORM_RELFLAGS += -fno-common -ffixed-r8 -msoft-float
> > > >++PLATFORM_RELFLAGS += -fno-common -ffixed-r8 -msoft-float -mno-
> > > >unaligned-access
> > > >+
> > > >+ # If armv7-a is not supported by GCC fall-back to armv5, which
> > > >is
> > > >+ # supported by more tool-chains
> > > >+--
> > > >+1.7.9.5
> > > >+
> > > >diff --git a/recipes-bsp/u-boot/u-boot-am37x_2012.04.01.bb
> > > >b/recipes-bsp/u-boot/u-boot-am37x_2012.04.01.bb
> > > >index c25cf1e..1cd96b6 100644
> > > >--- a/recipes-bsp/u-boot/u-boot-am37x_2012.04.01.bb
> > > >+++ b/recipes-bsp/u-boot/u-boot-am37x_2012.04.01.bb
> > > >@@ -6,6 +6,8 @@ COMPATIBLE_MACHINE = "am37x-evm|beagleboard"
> > > >
> > > > BRANCH ?= "master"
> > > >
> > > >+PR = "r1+gitr${SRCPV}"
> > > >+
> > > > # v2012.04.01
> > > > SRCREV = "415d386877df49eb051b85ef74fa59a16dc17c7d"
> > > >
> > > >@@ -33,6 +35,7 @@ SRC_URI += "file://0001-omap3_beagle-add-
> > > >usbethaddr-setting-to-enable-networ.pat
> > > > file://0002-omap3evm-Make-the-board-start-at-
> > > >800MHz.patch \
> > > > file://0003-beagleboard-Make-xM-rev-C-go-to-
> > > >800MHz.patch \
> > > > file://0001-ARM-omap3-Set-SPL-stack-size-to-8KB-
> > > >image-to-54KB.patch \
> > > >+ file://0001-armv7-Unaligned-access-fix.patch \
> > > > "
> > > >
> > > > SPL_BINARY = "MLO"
> > > >--
> > > >1.7.0.4
> > > >
> > > >_______________________________________________
> > > >meta-ti mailing list
> > > >meta-ti@yoctoproject.org
> > > >https://lists.yoctoproject.org/listinfo/meta-ti
> > > _______________________________________________
> > > meta-ti mailing list
> > > meta-ti@yoctoproject.org
> > > https://lists.yoctoproject.org/listinfo/meta-ti
next prev parent reply other threads:[~2013-07-09 19:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-02 16:47 [master & danny][PATCH 1/2] u-boot-am33x: Update am335x to use latest u-boot for 3.2 kernel Franklin S. Cooper Jr
2013-07-02 16:48 ` [master & danny][PATCH 2/2] u-boot: Add memory alignment fix for armv7 for am37x and am3517 Franklin S. Cooper Jr
2013-07-02 19:09 ` Maupin, Chase
2013-07-09 16:53 ` Denys Dmytriyenko
2013-07-09 19:04 ` Cooper Jr., Franklin
2013-07-09 19:07 ` Denys Dmytriyenko [this message]
2013-07-02 19:07 ` [master & danny][PATCH 1/2] u-boot-am33x: Update am335x to use latest u-boot for 3.2 kernel Maupin, Chase
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130709190756.GO14185@edge \
--to=denys@ti.com \
--cc=fcooper@ti.com \
--cc=meta-ti@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.