From: "Michael S. Tsirkin" <mst@redhat.com>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [PATCH 1/2] virtio tools: strip bad include-path from Makefile
Date: Wed, 10 Jul 2013 16:26:46 +0300 [thread overview]
Message-ID: <20130710132646.GA13131@redhat.com> (raw)
In-Reply-To: <CALkWK0ky0o-YX7935-sbuunk=HU-=pg8sZiBKiV3P5g9t1zMhQ@mail.gmail.com>
On Wed, Jul 10, 2013 at 06:52:09PM +0530, Ramkumar Ramachandra wrote:
> Michael S. Tsirkin wrote:
> > This is usespace code so it needs the cleaned-up version from
> > usr/include, not the internal kernel one.
>
> Right, thanks for clearing that up. However, it does seem to depend
> on some code in /include in the linux tree. From
> tools/virtio/linux/virtio_ring.h:
>
> #include "../../../include/linux/virtio_ring.h"
Yes, this is because we take some kernel bits
and compile as userspace. But it's fragile and it only works
for specific headers.
--
MST
next prev parent reply other threads:[~2013-07-10 13:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-10 10:56 [PATCH 0/2] virtio tools: build failure Ramkumar Ramachandra
2013-07-10 10:56 ` [PATCH 1/2] virtio tools: strip bad include-path from Makefile Ramkumar Ramachandra
2013-07-10 12:15 ` Michael S. Tsirkin
2013-07-10 12:20 ` Ramkumar Ramachandra
2013-07-10 12:42 ` Michael S. Tsirkin
2013-07-10 13:22 ` Ramkumar Ramachandra
2013-07-10 13:26 ` Michael S. Tsirkin [this message]
2013-07-10 10:57 ` [PATCH] virtio tools: add .gitignore Ramkumar Ramachandra
2013-07-10 12:16 ` Michael S. Tsirkin
2013-07-11 2:54 ` Rusty Russell
2013-07-10 12:18 ` [PATCH 0/2] virtio tools: build failure Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130710132646.GA13131@redhat.com \
--to=mst@redhat.com \
--cc=artagnon@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.