All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: mtosatti@redhat.com, mingo@redhat.com, gleb@redhat.com,
	glommer@parallels.com, tglx@linutronix.de, jeremy@goop.org,
	rostedt@goodmis.org, linux-kernel@vger.kernel.org
Subject: Re: sched: add notifier for cross-cpu migrations
Date: Wed, 10 Jul 2013 16:39:02 +0200	[thread overview]
Message-ID: <20130710143902.GA28514@gmail.com> (raw)
In-Reply-To: <20130710103440.GO25631@dyad.programming.kicks-ass.net>


* Peter Zijlstra <peterz@infradead.org> wrote:

> Hi,
> 
> I just stumbled over commit 582b336ec2 and had a massive WTF moment.
> 
> The Changelog -- empty!
> The Implementation -- complete crap!
> 
> fail^2.
> 
> A git grep later I find its x86_64 paravirt only.. for this we add 
> unconditional crap to the scheduler?
> 
> At the _very_ least this should have been wrapped in a static_key and 
> the changelog should have given some clue as to the what and why of this 
> code.

My bad for letting it slip through...

Marcelo, mind implementing the suggestions from Peter?

Thanks,

	Ingo

  reply	other threads:[~2013-07-10 14:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-10 10:34 sched: add notifier for cross-cpu migrations Peter Zijlstra
2013-07-10 14:39 ` Ingo Molnar [this message]
2013-07-10 14:52   ` Peter Zijlstra
2013-07-11  1:21 ` [PATCH] remove sched " Marcelo Tosatti
2013-07-11  8:10   ` Gleb Natapov
2013-07-11 22:15     ` Marcelo Tosatti
2013-07-11  9:52   ` Peter Zijlstra
2013-07-14 11:16   ` Gleb Natapov
2013-08-23 10:22   ` Peter Zijlstra
2013-08-23 10:31     ` Gleb Natapov
2013-08-23 10:34       ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130710143902.GA28514@gmail.com \
    --to=mingo@kernel.org \
    --cc=gleb@redhat.com \
    --cc=glommer@parallels.com \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.