From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: omap2: add select of TI_PRIV_EDMA
Date: Wed, 10 Jul 2013 16:36:57 +0200 [thread overview]
Message-ID: <201307101636.57623.arnd@arndb.de> (raw)
In-Reply-To: <51DD6FA9.8080908@ti.com>
On Wednesday 10 July 2013, Sekhar Nori wrote:
> On 7/10/2013 1:20 PM, Tony Lindgren wrote:
> > * Olof Johansson <olof@lixom.net> [130709 01:44]:
> >> "ARM: OMAP: build mach-omap code only if needed" moved around the
> >> ARCH_OMAP2PLUS stanza, but accidentally dropped the seleciton of
> >> TI_PRIV_EDMA in the process. Add it back.
> >>
> >> Cc: Arnd Bergmann <arnd@arndb.de>
> >
> > Acked-by: Tony Lindgren <tony@atomide.com>
> >
> >> Signed-off-by: Olof Johansson <olof@lixom.net>
>
> Thinking more, I do not think we should be selecting TI_PRIV_EDMA for
> OMAP2PLUS. There is no part of mach-omap2 that depends directly on
> TI_PRIV_EDMA being enabled.
>
> Instead, TI_PRIV_EDMA should be selected by the DMA engine driver as
> done in the patch here:
>
> http://www.spinics.net/lists/kernel/msg1563777.html
>
> Its the DMA engine driver which makes the private DMA calls so this
> patch is better.
I would have done 'depends on TI_PRIV_EDMA' instead, but any of the three
solutions is fine with me.
Arnd
next prev parent reply other threads:[~2013-07-10 14:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-09 8:37 [PATCH] ARM: omap2: add select of TI_PRIV_EDMA Olof Johansson
2013-07-10 7:50 ` Tony Lindgren
2013-07-10 14:28 ` Sekhar Nori
2013-07-10 14:36 ` Arnd Bergmann [this message]
2013-07-10 14:41 ` Sekhar Nori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201307101636.57623.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.