All of lore.kernel.org
 help / color / mirror / Atom feed
diff for duplicates of <20130710181248.GA22430@roeck-us.net>

diff --git a/a/1.txt b/N1/1.txt
index c08b4c6..08837a5 100644
--- a/a/1.txt
+++ b/N1/1.txt
@@ -3,7 +3,7 @@ On Wed, Jul 10, 2013 at 10:05:53AM -0700, Thierry Reding wrote:
 > > When the temperature exceed the limit range value,
 > > the driver can handle the interrupt.
 > > 
-> > Signed-off-by: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
+> > Signed-off-by: Wei Ni <wni@nvidia.com>
 > > ---
 > >  drivers/hwmon/lm90.c |   77 +++++++++++++++++++++++++++++++++++++++++---------
 > >  1 file changed, 64 insertions(+), 13 deletions(-)
@@ -93,21 +93,21 @@ Correct.
 > > +
 > > +	lm90_read_reg(client, LM90_REG_R_STATUS, &alarms);
 > > +
-> > +	if (data->kind == max6696)
+> > +	if (data->kind = max6696)
 > > +		lm90_read_reg(client, MAX6696_REG_R_STATUS2, &alarms_max6696);
 > > +
-> > +	if ((alarms & 0x7f) == 0 && (alarms_max6696 & 0xfe) == 0) {
+> > +	if ((alarms & 0x7f) = 0 && (alarms_max6696 & 0xfe) = 0) {
 > > +		return IRQ_NONE;
 > 
 > For non-MAX6696 chips this will evaluate to:
 > 
-> 	if ((alarms & 0x7f) == 0 && (0 & 0xfe) == 0)
+> 	if ((alarms & 0x7f) = 0 && (0 & 0xfe) = 0)
 > 
 > and therefore be true for any value of "alarms" and therefore always
 > result in IRQ_NONE being returned.
 > 
 Not really. If
-	(alarms & 0xfe) == 0
+	(alarms & 0xfe) = 0
 returns false (ie thee is an alarm) the expression is false and the
 if statement won't be executed. Or maybe I didn't get enough sleep
 last night ;).
@@ -125,3 +125,10 @@ select a generic name for the variable from the beginning (status and status2
 would do quite nicely).
 
 > Thierry
+
+
+
+_______________________________________________
+lm-sensors mailing list
+lm-sensors@lm-sensors.org
+http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
diff --git a/a/content_digest b/N1/content_digest
index 1b3085f..481ef67 100644
--- a/a/content_digest
+++ b/N1/content_digest
@@ -2,9 +2,9 @@
  "ref\01373455539-2831-3-git-send-email-wni@nvidia.com\0"
  "ref\020130710170552.GA15665@dhcp-172-17-186-34.nvidia.com\0"
  "ref\020130710170552.GA15665-RcKxWJ4Cfj3FNiLNb7+IINdj8bHVeoWogfoxzgwHRXE@public.gmane.org\0"
- "From\0Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>\0"
- "Subject\0Re: [PATCH v2 2/3] hwmon: (lm90) add support to handle IRQ.\0"
- "Date\0Wed, 10 Jul 2013 11:12:49 -0700\0"
+ "From\0Guenter Roeck <linux@roeck-us.net>\0"
+ "Subject\0Re: [lm-sensors] [PATCH v2 2/3] hwmon: (lm90) add support to handle IRQ.\0"
+ "Date\0Wed, 10 Jul 2013 18:12:49 +0000\0"
  "To\0Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>\0"
  "Cc\0Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>"
   khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org
@@ -19,7 +19,7 @@
  "> > When the temperature exceed the limit range value,\n"
  "> > the driver can handle the interrupt.\n"
  "> > \n"
- "> > Signed-off-by: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>\n"
+ "> > Signed-off-by: Wei Ni <wni@nvidia.com>\n"
  "> > ---\n"
  "> >  drivers/hwmon/lm90.c |   77 +++++++++++++++++++++++++++++++++++++++++---------\n"
  "> >  1 file changed, 64 insertions(+), 13 deletions(-)\n"
@@ -109,21 +109,21 @@
  "> > +\n"
  "> > +\tlm90_read_reg(client, LM90_REG_R_STATUS, &alarms);\n"
  "> > +\n"
- "> > +\tif (data->kind == max6696)\n"
+ "> > +\tif (data->kind = max6696)\n"
  "> > +\t\tlm90_read_reg(client, MAX6696_REG_R_STATUS2, &alarms_max6696);\n"
  "> > +\n"
- "> > +\tif ((alarms & 0x7f) == 0 && (alarms_max6696 & 0xfe) == 0) {\n"
+ "> > +\tif ((alarms & 0x7f) = 0 && (alarms_max6696 & 0xfe) = 0) {\n"
  "> > +\t\treturn IRQ_NONE;\n"
  "> \n"
  "> For non-MAX6696 chips this will evaluate to:\n"
  "> \n"
- "> \tif ((alarms & 0x7f) == 0 && (0 & 0xfe) == 0)\n"
+ "> \tif ((alarms & 0x7f) = 0 && (0 & 0xfe) = 0)\n"
  "> \n"
  "> and therefore be true for any value of \"alarms\" and therefore always\n"
  "> result in IRQ_NONE being returned.\n"
  "> \n"
  "Not really. If\n"
- "\t(alarms & 0xfe) == 0\n"
+ "\t(alarms & 0xfe) = 0\n"
  "returns false (ie thee is an alarm) the expression is false and the\n"
  "if statement won't be executed. Or maybe I didn't get enough sleep\n"
  "last night ;).\n"
@@ -140,6 +140,13 @@
  "select a generic name for the variable from the beginning (status and status2\n"
  "would do quite nicely).\n"
  "\n"
- > Thierry
+ "> Thierry\n"
+ "\n"
+ "\n"
+ "\n"
+ "_______________________________________________\n"
+ "lm-sensors mailing list\n"
+ "lm-sensors@lm-sensors.org\n"
+ http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
 
-e3951475b4748869515d6c0d8abaedd2af93ba9ae90f293fa5d366298e9e8399
+1a3c9a0ecd004463748746ea69ed5db48272ab8862fb63a26c4675f2639619c5

diff --git a/a/1.txt b/N2/1.txt
index c08b4c6..6a846df 100644
--- a/a/1.txt
+++ b/N2/1.txt
@@ -3,7 +3,7 @@ On Wed, Jul 10, 2013 at 10:05:53AM -0700, Thierry Reding wrote:
 > > When the temperature exceed the limit range value,
 > > the driver can handle the interrupt.
 > > 
-> > Signed-off-by: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
+> > Signed-off-by: Wei Ni <wni@nvidia.com>
 > > ---
 > >  drivers/hwmon/lm90.c |   77 +++++++++++++++++++++++++++++++++++++++++---------
 > >  1 file changed, 64 insertions(+), 13 deletions(-)
diff --git a/a/content_digest b/N2/content_digest
index 1b3085f..5aae1d7 100644
--- a/a/content_digest
+++ b/N2/content_digest
@@ -1,17 +1,16 @@
  "ref\01373455539-2831-1-git-send-email-wni@nvidia.com\0"
  "ref\01373455539-2831-3-git-send-email-wni@nvidia.com\0"
  "ref\020130710170552.GA15665@dhcp-172-17-186-34.nvidia.com\0"
- "ref\020130710170552.GA15665-RcKxWJ4Cfj3FNiLNb7+IINdj8bHVeoWogfoxzgwHRXE@public.gmane.org\0"
- "From\0Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>\0"
+ "From\0Guenter Roeck <linux@roeck-us.net>\0"
  "Subject\0Re: [PATCH v2 2/3] hwmon: (lm90) add support to handle IRQ.\0"
  "Date\0Wed, 10 Jul 2013 11:12:49 -0700\0"
- "To\0Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>\0"
- "Cc\0Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>"
-  khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org
-  swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org
-  lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
-  linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
- " linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org\0"
+ "To\0Thierry Reding <thierry.reding@gmail.com>\0"
+ "Cc\0Wei Ni <wni@nvidia.com>"
+  khali@linux-fr.org
+  swarren@wwwdotorg.org
+  lm-sensors@lm-sensors.org
+  linux-kernel@vger.kernel.org
+ " linux-tegra@vger.kernel.org\0"
  "\00:1\0"
  "b\0"
  "On Wed, Jul 10, 2013 at 10:05:53AM -0700, Thierry Reding wrote:\n"
@@ -19,7 +18,7 @@
  "> > When the temperature exceed the limit range value,\n"
  "> > the driver can handle the interrupt.\n"
  "> > \n"
- "> > Signed-off-by: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>\n"
+ "> > Signed-off-by: Wei Ni <wni@nvidia.com>\n"
  "> > ---\n"
  "> >  drivers/hwmon/lm90.c |   77 +++++++++++++++++++++++++++++++++++++++++---------\n"
  "> >  1 file changed, 64 insertions(+), 13 deletions(-)\n"
@@ -142,4 +141,4 @@
  "\n"
  > Thierry
 
-e3951475b4748869515d6c0d8abaedd2af93ba9ae90f293fa5d366298e9e8399
+dde72079d7a581b1b59ae1e70f3cb5fafacb818795696c1490c84d0ddb1bd352

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.