diff for duplicates of <20130710182154.GC22430@roeck-us.net> diff --git a/a/1.txt b/N1/1.txt index 26b4fff..84dee1e 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -2,7 +2,7 @@ On Wed, Jul 10, 2013 at 07:25:37PM +0800, Wei Ni wrote: > Split set&show temp codes as common functions, so we can use it directly when > implement linux thermal framework. > -> Signed-off-by: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> +> Signed-off-by: Wei Ni <wni@nvidia.com> > --- > drivers/hwmon/lm90.c | 118 ++++++++++++++++++++++++++++++++------------------ > 1 file changed, 75 insertions(+), 43 deletions(-) @@ -26,10 +26,10 @@ On Wed, Jul 10, 2013 at 07:25:37PM +0800, Wei Ni wrote: > Why this reordering of variables ? -> if (data->kind == adt7461) +> if (data->kind = adt7461) > - temp = temp_from_u8_adt7461(data, data->temp8[attr->index]); > + temp = temp_from_u8_adt7461(data, data->temp8[index]); -> else if (data->kind == max6646) +> else if (data->kind = max6646) > - temp = temp_from_u8(data->temp8[attr->index]); > + temp = temp_from_u8(data->temp8[index]); > else @@ -37,8 +37,8 @@ Why this reordering of variables ? > + temp = temp_from_s8(data->temp8[index]); > > /* +16 degrees offset for temp2 for the LM99 */ -> - if (data->kind == lm99 && attr->index == 3) -> + if (data->kind == lm99 && index == 3) +> - if (data->kind = lm99 && attr->index = 3) +> + if (data->kind = lm99 && index = 3) > temp += 16000; > > + return temp; @@ -81,15 +81,15 @@ Might as well simplify with > - return err; > > /* +16 degrees offset for temp2 for the LM99 */ -> - if (data->kind == lm99 && attr->index == 3) -> + if (data->kind == lm99 && index == 3) +> - if (data->kind = lm99 && attr->index = 3) +> + if (data->kind = lm99 && index = 3) > val -= 16000; > > mutex_lock(&data->update_lock); -> if (data->kind == adt7461) +> if (data->kind = adt7461) > - data->temp8[nr] = temp_to_u8_adt7461(data, val); > + data->temp8[index] = temp_to_u8_adt7461(data, val); -> else if (data->kind == max6646) +> else if (data->kind = max6646) > - data->temp8[nr] = temp_to_u8(val); > + data->temp8[index] = temp_to_u8(val); > else @@ -133,10 +133,10 @@ Might as well simplify with > Another unnecessary variable reorder. -> if (data->kind == adt7461) +> if (data->kind = adt7461) > - temp = temp_from_u16_adt7461(data, data->temp11[attr->index]); > + temp = temp_from_u16_adt7461(data, data->temp11[index]); -> else if (data->kind == max6646) +> else if (data->kind = max6646) > - temp = temp_from_u16(data->temp11[attr->index]); > + temp = temp_from_u16(data->temp11[index]); > else @@ -144,8 +144,8 @@ Another unnecessary variable reorder. > + temp = temp_from_s16(data->temp11[index]); > > /* +16 degrees offset for temp2 for the LM99 */ -> - if (data->kind == lm99 && attr->index <= 2) -> + if (data->kind == lm99 && index <= 2) +> - if (data->kind = lm99 && attr->index <= 2) +> + if (data->kind = lm99 && index <= 2) > temp += 16000; > > + return temp; @@ -188,7 +188,7 @@ Same simplification as above. > - return err; > > /* +16 degrees offset for temp2 for the LM99 */ -> if (data->kind == lm99 && index <= 2) +> if (data->kind = lm99 && index <= 2) > @@ -839,6 +854,23 @@ static ssize_t set_temp11(struct device *dev, struct device_attribute *devattr, > lm90_select_remote_channel(client, data, 0); > @@ -216,4 +216,9 @@ Same simplification as above. > -- > 1.7.9.5 > -> +> + +_______________________________________________ +lm-sensors mailing list +lm-sensors@lm-sensors.org +http://lists.lm-sensors.org/mailman/listinfo/lm-sensors diff --git a/a/content_digest b/N1/content_digest index 925769f..311152e 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,9 +1,9 @@ "ref\01373455539-2831-1-git-send-email-wni@nvidia.com\0" "ref\01373455539-2831-2-git-send-email-wni@nvidia.com\0" "ref\01373455539-2831-2-git-send-email-wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org\0" - "From\0Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>\0" - "Subject\0Re: [PATCH v2 1/3] hwmon: (lm90) split set&show temp as common codes\0" - "Date\0Wed, 10 Jul 2013 11:21:54 -0700\0" + "From\0Guenter Roeck <linux@roeck-us.net>\0" + "Subject\0Re: [lm-sensors] [PATCH v2 1/3] hwmon: (lm90) split set&show temp as common codes\0" + "Date\0Wed, 10 Jul 2013 18:21:54 +0000\0" "To\0Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>\0" "Cc\0khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org" swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org @@ -17,7 +17,7 @@ "> Split set&show temp codes as common functions, so we can use it directly when\n" "> implement linux thermal framework.\n" "> \n" - "> Signed-off-by: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>\n" + "> Signed-off-by: Wei Ni <wni@nvidia.com>\n" "> ---\n" "> drivers/hwmon/lm90.c | 118 ++++++++++++++++++++++++++++++++------------------\n" "> 1 file changed, 75 insertions(+), 43 deletions(-)\n" @@ -41,10 +41,10 @@ "> \n" "Why this reordering of variables ?\n" "\n" - "> \tif (data->kind == adt7461)\n" + "> \tif (data->kind = adt7461)\n" "> -\t\ttemp = temp_from_u8_adt7461(data, data->temp8[attr->index]);\n" "> +\t\ttemp = temp_from_u8_adt7461(data, data->temp8[index]);\n" - "> \telse if (data->kind == max6646)\n" + "> \telse if (data->kind = max6646)\n" "> -\t\ttemp = temp_from_u8(data->temp8[attr->index]);\n" "> +\t\ttemp = temp_from_u8(data->temp8[index]);\n" "> \telse\n" @@ -52,8 +52,8 @@ "> +\t\ttemp = temp_from_s8(data->temp8[index]);\n" "> \n" "> \t/* +16 degrees offset for temp2 for the LM99 */\n" - "> -\tif (data->kind == lm99 && attr->index == 3)\n" - "> +\tif (data->kind == lm99 && index == 3)\n" + "> -\tif (data->kind = lm99 && attr->index = 3)\n" + "> +\tif (data->kind = lm99 && index = 3)\n" "> \t\ttemp += 16000;\n" "> \n" "> +\treturn temp;\n" @@ -96,15 +96,15 @@ "> -\t\treturn err;\n" "> \n" "> \t/* +16 degrees offset for temp2 for the LM99 */\n" - "> -\tif (data->kind == lm99 && attr->index == 3)\n" - "> +\tif (data->kind == lm99 && index == 3)\n" + "> -\tif (data->kind = lm99 && attr->index = 3)\n" + "> +\tif (data->kind = lm99 && index = 3)\n" "> \t\tval -= 16000;\n" "> \n" "> \tmutex_lock(&data->update_lock);\n" - "> \tif (data->kind == adt7461)\n" + "> \tif (data->kind = adt7461)\n" "> -\t\tdata->temp8[nr] = temp_to_u8_adt7461(data, val);\n" "> +\t\tdata->temp8[index] = temp_to_u8_adt7461(data, val);\n" - "> \telse if (data->kind == max6646)\n" + "> \telse if (data->kind = max6646)\n" "> -\t\tdata->temp8[nr] = temp_to_u8(val);\n" "> +\t\tdata->temp8[index] = temp_to_u8(val);\n" "> \telse\n" @@ -148,10 +148,10 @@ "> \n" "Another unnecessary variable reorder.\n" "\n" - "> \tif (data->kind == adt7461)\n" + "> \tif (data->kind = adt7461)\n" "> -\t\ttemp = temp_from_u16_adt7461(data, data->temp11[attr->index]);\n" "> +\t\ttemp = temp_from_u16_adt7461(data, data->temp11[index]);\n" - "> \telse if (data->kind == max6646)\n" + "> \telse if (data->kind = max6646)\n" "> -\t\ttemp = temp_from_u16(data->temp11[attr->index]);\n" "> +\t\ttemp = temp_from_u16(data->temp11[index]);\n" "> \telse\n" @@ -159,8 +159,8 @@ "> +\t\ttemp = temp_from_s16(data->temp11[index]);\n" "> \n" "> \t/* +16 degrees offset for temp2 for the LM99 */\n" - "> -\tif (data->kind == lm99 && attr->index <= 2)\n" - "> +\tif (data->kind == lm99 && index <= 2)\n" + "> -\tif (data->kind = lm99 && attr->index <= 2)\n" + "> +\tif (data->kind = lm99 && index <= 2)\n" "> \t\ttemp += 16000;\n" "> \n" "> +\treturn temp;\n" @@ -203,7 +203,7 @@ "> -\t\treturn err;\n" "> \n" "> \t/* +16 degrees offset for temp2 for the LM99 */\n" - "> \tif (data->kind == lm99 && index <= 2)\n" + "> \tif (data->kind = lm99 && index <= 2)\n" "> @@ -839,6 +854,23 @@ static ssize_t set_temp11(struct device *dev, struct device_attribute *devattr,\n" "> \tlm90_select_remote_channel(client, data, 0);\n" "> \n" @@ -231,6 +231,11 @@ "> -- \n" "> 1.7.9.5\n" "> \n" - > + "> \n" + "\n" + "_______________________________________________\n" + "lm-sensors mailing list\n" + "lm-sensors@lm-sensors.org\n" + http://lists.lm-sensors.org/mailman/listinfo/lm-sensors -e752a9918bd03935fbf26a44282c071d2a26d13ab3a74aa52efd51e347d6b43a +24770875cb6069dd4c91498274d8e9e21d9612b0b080e091576449924ed88ce6
diff --git a/a/1.txt b/N2/1.txt index 26b4fff..a71121d 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -2,7 +2,7 @@ On Wed, Jul 10, 2013 at 07:25:37PM +0800, Wei Ni wrote: > Split set&show temp codes as common functions, so we can use it directly when > implement linux thermal framework. > -> Signed-off-by: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> +> Signed-off-by: Wei Ni <wni@nvidia.com> > --- > drivers/hwmon/lm90.c | 118 ++++++++++++++++++++++++++++++++------------------ > 1 file changed, 75 insertions(+), 43 deletions(-) diff --git a/a/content_digest b/N2/content_digest index 925769f..7ea4633 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,23 +1,22 @@ "ref\01373455539-2831-1-git-send-email-wni@nvidia.com\0" "ref\01373455539-2831-2-git-send-email-wni@nvidia.com\0" - "ref\01373455539-2831-2-git-send-email-wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org\0" - "From\0Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>\0" + "From\0Guenter Roeck <linux@roeck-us.net>\0" "Subject\0Re: [PATCH v2 1/3] hwmon: (lm90) split set&show temp as common codes\0" "Date\0Wed, 10 Jul 2013 11:21:54 -0700\0" - "To\0Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>\0" - "Cc\0khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org" - swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org - thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org - lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org - linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - " linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org\0" + "To\0Wei Ni <wni@nvidia.com>\0" + "Cc\0khali@linux-fr.org" + swarren@wwwdotorg.org + thierry.reding@gmail.com + lm-sensors@lm-sensors.org + linux-kernel@vger.kernel.org + " linux-tegra@vger.kernel.org\0" "\00:1\0" "b\0" "On Wed, Jul 10, 2013 at 07:25:37PM +0800, Wei Ni wrote:\n" "> Split set&show temp codes as common functions, so we can use it directly when\n" "> implement linux thermal framework.\n" "> \n" - "> Signed-off-by: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>\n" + "> Signed-off-by: Wei Ni <wni@nvidia.com>\n" "> ---\n" "> drivers/hwmon/lm90.c | 118 ++++++++++++++++++++++++++++++++------------------\n" "> 1 file changed, 75 insertions(+), 43 deletions(-)\n" @@ -233,4 +232,4 @@ "> \n" > -e752a9918bd03935fbf26a44282c071d2a26d13ab3a74aa52efd51e347d6b43a +3c6b0bcf66043379e170ee954169ba480769d6400f14eb93033bf3b2574b71e1
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.