From: Andrew Vagin <avagin@gmail.com>
To: Mark Fasheh <mfasheh@suse.de>
Cc: dsterba@suse.cz, Chris Mason <chris.mason@fusionio.com>,
linux-btrfs@vger.kernel.org, kzak@redhat.com, xemul@openvz.org
Subject: Re: btrfs: stat(2) and /proc/pid/maps returns different devices
Date: Fri, 12 Jul 2013 01:25:31 +0400 [thread overview]
Message-ID: <20130711212531.GA11963@gmail.com> (raw)
In-Reply-To: <20130710174545.GS32502@wotan.suse.de>
On Wed, Jul 10, 2013 at 10:45:45AM -0700, Mark Fasheh wrote:
> On Wed, Jul 10, 2013 at 09:31:05AM -0700, Mark Fasheh wrote:
> > As far as I can tell we'll be carrying this patch until a better
> > solution is possible.
> >
> > When that will happen, I don't know.
> > --Mark
>
> Well, what do I get when I pretend I don't care any more? The little voice
> in my head says "keep plugging away". Here's another attempt at fixing this
> problem in a sane manner. Basically, this time we're adding a flag to
> s_flags which btrfs sets. Proc will see the flag and call ->getattr().
>
> This compiles, but it needs testing (which I will get to soon). It still has
> a bunch of problems in my honest opinion but maybe if we get something
> acceptable upstream we can work from there.
>
> Also, as Andrew pointed out there's more than one place which is return
> different device than from stat(2) so I probably need to update more sites
> to deal with this.
Yes, we need to fix unix_diag, fanotify fdinfo, ...
>
> Does anyone see a problem with this approach?
Looks good for me. Thanks.
> --Mark
>
> --
> Mark Fasheh
>
prev parent reply other threads:[~2013-07-11 21:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-04 9:51 btrfs: stat(2) and /proc/pid/maps returns different devices Andrew Vagin
2013-07-05 8:06 ` Andrey Wagin
2013-07-08 21:54 ` David Sterba
2013-07-10 16:31 ` Mark Fasheh
2013-07-10 17:45 ` Mark Fasheh
2013-07-10 22:26 ` David Sterba
2013-07-19 20:51 ` Mark Fasheh
2013-07-31 18:24 ` David Sterba
2013-10-24 10:41 ` Pavel Emelyanov
2013-07-11 21:25 ` Andrew Vagin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130711212531.GA11963@gmail.com \
--to=avagin@gmail.com \
--cc=chris.mason@fusionio.com \
--cc=dsterba@suse.cz \
--cc=kzak@redhat.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=mfasheh@suse.de \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.