All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Myers <bpm@sgi.com>
To: Chandra Seetharaman <sekharan@us.ibm.com>
Cc: XFS mailing list <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs: Fix the logic check for all quotas being turned off
Date: Thu, 11 Jul 2013 16:41:44 -0500	[thread overview]
Message-ID: <20130711214144.GD20932@sgi.com> (raw)
In-Reply-To: <1373497236.6020.36.camel@chandra-dt.ibm.com>

On Wed, Jul 10, 2013 at 06:00:36PM -0500, Chandra Seetharaman wrote:
> 
> During the review of seperate pquota inode patches, David noticed
> that the test to detect all quotas being turned off was
> incorrect, and hence the block was not freeing all the quota
> information.
> 
> The check made sense in Irix, but in Linux, quota is turned off
> one at a time, which makes the test invalid for Linux.
> 
> This problem existed since XFS was ported to Linux.
> 
> David suggested to fix the problem by detecting when all quotas are
> turned off by checking m_qflags.
> 
> Signed-off-by: Chandra Seetharaman <sekharan@us.ibm.com>

This looks ok to me. 

Reviewed-by: Ben Myers <bpm@sgi.com>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      reply	other threads:[~2013-07-11 21:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-10 23:00 [PATCH] xfs: Fix the logic check for all quotas being turned off Chandra Seetharaman
2013-07-11 21:41 ` Ben Myers [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130711214144.GD20932@sgi.com \
    --to=bpm@sgi.com \
    --cc=sekharan@us.ibm.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.