From: Nishanth Menon <nm@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/5] omap3_beagle: remove JFFS2 support.
Date: Thu, 11 Jul 2013 22:49:22 -0500 [thread overview]
Message-ID: <20130712034922.GA20823@kahuna> (raw)
In-Reply-To: <51DF6EB0.6020108@ti.com>
On 21:49-20130711, Joel Fernandes wrote:
> On Thu, Jul 11, 2013 at 4:52 PM, Nishanth Menon <nm@ti.com> wrote:
> > We do not use JFFS2 by default and it conflicts with
> > CONFIG_CMD_FS_GENERIC (ls command is the same). Since most of our
> > BOOTCMD can be simplified by using the FS_GENERIC, dropping JFFS2
> >
> > Signed-off-by: Nishanth Menon <nm@ti.com>
> > ---
> > include/configs/omap3_beagle.h | 8 --------
> > 1 file changed, 8 deletions(-)
> >
> > diff --git a/include/configs/omap3_beagle.h b/include/configs/omap3_beagle.h
> > index 48ce4c0..9adf4a5 100644
> > --- a/include/configs/omap3_beagle.h
> > +++ b/include/configs/omap3_beagle.h
> > @@ -150,7 +150,6 @@
> > #define CONFIG_CMD_CACHE
> > #define CONFIG_CMD_EXT2 /* EXT2 Support */
> > #define CONFIG_CMD_FAT /* FAT support */
> > -#define CONFIG_CMD_JFFS2 /* JFFS2 Support */
> > #define CONFIG_CMD_MTDPARTS /* Enable MTD parts commands */
> > #define CONFIG_MTD_DEVICE /* needed for mtdparts commands */
> > #define MTDIDS_DEFAULT "nand0=nand"
> > @@ -203,13 +202,6 @@
> >
> > #define CONFIG_SYS_MAX_NAND_DEVICE 1 /* Max number of NAND */
> > /* devices */
> > -#define CONFIG_JFFS2_NAND
> > -/* nand device jffs2 lives on */
> > -#define CONFIG_JFFS2_DEV "nand0"
> > -/* start of jffs2 partition */
> > -#define CONFIG_JFFS2_PART_OFFSET 0x680000
> > -#define CONFIG_JFFS2_PART_SIZE 0xf980000 /* size of jffs2 */
> >
>
> Minor nit, can we perhaps leave the JFFS configuration and only remove/comment
> CONFIG_CMD_JFFS. That way we wont lose these paritition offsets/size for folks
> who might need them.
then we have to drop the usage of FS_GENERIC. code wont build with both.
There is no point in keeping something as an option if it cant be used.
dont you agree?
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2013-07-12 3:49 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-11 21:52 [U-Boot] [PATCH 0/5] omap3_beagle: configs: improve BOOT_CMD options Nishanth Menon
2013-07-11 21:52 ` [U-Boot] [PATCH 1/5] omap3_beagle: remove JFFS2 support Nishanth Menon
2013-07-12 2:49 ` Joel Fernandes
2013-07-12 3:49 ` Nishanth Menon [this message]
2013-07-12 4:25 ` Joel Fernandes
2013-07-12 4:35 ` Nishanth Menon
2013-07-11 21:52 ` [U-Boot] [PATCH 2/5] omap3_beagle: replace uImage.beagle with generic uImage Nishanth Menon
2013-07-11 21:52 ` [U-Boot] [PATCH 3/5] omap3_beagle: enable CMD_FS_GENERIC and simplify load of image/ramdisk Nishanth Menon
2013-07-11 22:33 ` [U-Boot] [PATCH V2 0/6] omap3_beagle: configs: improve BOOT_CMD options Nishanth Menon
2013-07-11 22:33 ` [U-Boot] [PATCH V2 1/6] omap3_beagle: remove JFFS2 support Nishanth Menon
2013-07-11 22:33 ` [U-Boot] [PATCH V2 2/6] omap3_beagle: replace uImage.beagle with generic uImage Nishanth Menon
2013-07-11 22:33 ` [U-Boot] [PATCH V2 3/6] beagleboard: remove RevB support for BeagleBoard Xm Nishanth Menon
2013-07-11 22:33 ` [U-Boot] [PATCH V2 4/6] omap3_beagle: enable CMD_FS_GENERIC and simplify load of image/ramdisk Nishanth Menon
2013-07-11 22:33 ` [U-Boot] [PATCH V2 5/6] omap3_beagle: support findfdt and loadfdt for devicetree support Nishanth Menon
2013-07-11 22:37 ` Nishanth Menon
2013-07-11 22:33 ` [U-Boot] [PATCH V2 6/6] omap3_beagle: support booting from zImage and device tree as last option Nishanth Menon
2013-07-12 15:10 ` [U-Boot] [PATCH V2 0/6] omap3_beagle: configs: improve BOOT_CMD options Tom Rini
2013-07-15 12:11 ` [U-Boot] [PATCH V3 " Nishanth Menon
2013-07-15 12:11 ` [U-Boot] [PATCH V3 1/6] omap3_beagle: remove JFFS2 support Nishanth Menon
2013-07-15 12:11 ` [U-Boot] [PATCH V3 2/6] omap3_beagle: replace uImage.beagle with generic uImage Nishanth Menon
2013-07-15 12:11 ` [U-Boot] [PATCH V3 3/6] beagleboard: remove RevB support for BeagleBoard Xm Nishanth Menon
2013-07-15 12:11 ` [U-Boot] [PATCH V3 4/6] omap3_beagle: enable CMD_FS_GENERIC and simplify load of image/ramdisk Nishanth Menon
2013-07-15 12:11 ` [U-Boot] [PATCH V3 5/6] omap3_beagle: support findfdt and loadfdt for devicetree support Nishanth Menon
2013-07-15 12:16 ` Koen Kooi
2013-07-15 12:25 ` Nishanth Menon
2013-07-15 13:07 ` Koen Kooi
2013-07-15 14:06 ` Nishanth Menon
2013-07-15 14:49 ` Tom Rini
2013-07-15 14:52 ` Koen Kooi
2013-07-18 16:13 ` Tom Rini
2013-07-18 18:42 ` Nishanth Menon
2013-07-15 12:11 ` [U-Boot] [PATCH V3 6/6] omap3_beagle: support booting from zImage and device tree as last option Nishanth Menon
2013-07-30 13:29 ` [U-Boot] [PATCH V3 0/6] omap3_beagle: configs: improve BOOT_CMD options Tom Rini
2013-07-11 21:52 ` [U-Boot] [PATCH 4/5] omap3_beagle: support findfdt and loadfdt for devicetree support Nishanth Menon
2013-07-11 22:02 ` Robert Nelson
2013-07-11 22:03 ` Nishanth Menon
2013-07-11 22:05 ` Robert Nelson
2013-07-11 22:17 ` Nishanth Menon
2013-07-11 23:17 ` Robert Nelson
2013-07-12 4:06 ` Nishanth Menon
2013-07-12 13:32 ` Robert Nelson
2013-07-12 14:28 ` Nishanth Menon
2013-07-11 21:52 ` [U-Boot] [PATCH 5/5] omap3_beagle: support booting from zImage and device tree as last option Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130712034922.GA20823@kahuna \
--to=nm@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.