From mboxrd@z Thu Jan 1 00:00:00 1970 From: majianpeng Subject: [PATCH] libceph: Unregister request if __map_request failed. Date: Fri, 12 Jul 2013 19:25:34 +0800 Message-ID: <201307121925324881460@gmail.com> Reply-To: majianpeng Mime-Version: 1.0 Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: base64 Return-path: Sender: linux-kernel-owner@vger.kernel.org To: sage Cc: ceph-devel , linux-kernel List-Id: ceph-devel.vger.kernel.org SW4gZnVuYyBjZXBoX29zZGNfc3RhcnRfcmVxdWVzdCwgaWYgX19tYXBlX3JlcXVlc3QgZmFpbGVk LCBpdCBzaG91bGQNCmNhbGwgX191bnJlZ2lzdGVyX3JlcXVlc3QgYXZvaWQgY2F1c2UgYnVncywg ZXRjIG1lbWxlYWssIHVtb3VudCBmcw0KZmFpbGVkLg0KDQpTaWduZWQtb2ZmLWJ5OiBKaWFucGVu ZyBNYSA8bWFqaWFucGVuZ0BnbWFpbC5jb20+DQotLS0NCiBuZXQvY2VwaC9vc2RfY2xpZW50LmMg fCAxICsNCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKykNCg0KZGlmZiAtLWdpdCBhL25l dC9jZXBoL29zZF9jbGllbnQuYyBiL25ldC9jZXBoL29zZF9jbGllbnQuYw0KaW5kZXggZGQ0Nzg4 OS4uNjM1NjUzOSAxMDA2NDQNCi0tLSBhL25ldC9jZXBoL29zZF9jbGllbnQuYw0KKysrIGIvbmV0 L2NlcGgvb3NkX2NsaWVudC5jDQpAQCAtMjEzMCw2ICsyMTMwLDcgQEAgaW50IGNlcGhfb3NkY19z dGFydF9yZXF1ZXN0KHN0cnVjdCBjZXBoX29zZF9jbGllbnQgKm9zZGMsDQogCQkJCSIgd2lsbCBy ZXRyeSAlbGxkXG4iLCByZXEtPnJfdGlkKTsNCiAJCQlyYyA9IDA7DQogCQl9DQorCQlfX3VucmVn aXN0ZXJfcmVxdWVzdChvc2RjLCByZXEpOw0KIAkJZ290byBvdXRfdW5sb2NrOw0KIAl9DQogCWlm IChyZXEtPnJfb3NkID09IE5VTEwpIHsNCi0tIA0KMS44LjEuMg0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932900Ab3GLLZu (ORCPT ); Fri, 12 Jul 2013 07:25:50 -0400 Received: from mail-pd0-f175.google.com ([209.85.192.175]:46277 "EHLO mail-pd0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932578Ab3GLLZs (ORCPT ); Fri, 12 Jul 2013 07:25:48 -0400 Date: Fri, 12 Jul 2013 19:25:34 +0800 From: majianpeng To: sage Cc: ceph-devel , linux-kernel Reply-To: majianpeng Subject: [PATCH] libceph: Unregister request if __map_request failed. X-Priority: 3 X-GUID: 914B6DD9-8552-40E0-952B-2B3787E5B710 X-Has-Attach: no X-Mailer: Foxmail 7.0.1.90[en] Mime-Version: 1.0 Message-ID: <201307121925324881460@gmail.com> Content-Type: text/plain; charset="gb2312" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id r6CBQ8fO029922 In func ceph_osdc_start_request, if __mape_request failed, it should call __unregister_request avoid cause bugs, etc memleak, umount fs failed. Signed-off-by: Jianpeng Ma --- net/ceph/osd_client.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/ceph/osd_client.c b/net/ceph/osd_client.c index dd47889..6356539 100644 --- a/net/ceph/osd_client.c +++ b/net/ceph/osd_client.c @@ -2130,6 +2130,7 @@ int ceph_osdc_start_request(struct ceph_osd_client *osdc, " will retry %lld\n", req->r_tid); rc = 0; } + __unregister_request(osdc, req); goto out_unlock; } if (req->r_osd == NULL) { -- 1.8.1.2 {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I