From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging/lustre/libcfs: fix typo "default false"
Date: Sat, 13 Jul 2013 09:07:16 -0700 [thread overview]
Message-ID: <20130713160716.GA2279@kroah.com> (raw)
In-Reply-To: <1373726446.1359.17.camel@x61.thuisdomein>
On Sat, Jul 13, 2013 at 04:40:46PM +0200, Paul Bolle wrote:
> Commit 4b5b4c7222 ("staging/lustre/libcfs: restore LINVRNT") added
> "default false" to this Kconfig file. It was obviously meant to use
> "default n" here.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> 0) Tested lightly, with "make menuconfig" only.
>
> 1) No-one noticed because "default <invalid Kconfig symbol>" and
> "default n" behave the same. Actually, it seems "default n" isn't needed
> at all. But there are hundreds of Kconfig symbols that use "default n",
> so I suppose it serves some purpose.
>
> drivers/staging/lustre/lustre/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lustre/Kconfig b/drivers/staging/lustre/lustre/Kconfig
> index e0eb830..002dd2e 100644
> --- a/drivers/staging/lustre/lustre/Kconfig
> +++ b/drivers/staging/lustre/lustre/Kconfig
> @@ -43,7 +43,7 @@ config LUSTRE_OBD_MAX_IOCTL_BUFFER
> config LUSTRE_DEBUG_EXPENSIVE_CHECK
> bool "Enable Lustre DEBUG checks"
> depends on LUSTRE_FS
> - default false
> + default n
Just remove it entirely, as you say, the default is 'n', so let's just
stick with that.
Care to redo this?
thanks,
greg k-h
next prev parent reply other threads:[~2013-07-13 16:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-13 14:40 [PATCH] staging/lustre/libcfs: fix typo "default false" Paul Bolle
2013-07-13 16:07 ` Greg Kroah-Hartman [this message]
2013-07-13 16:44 ` [PATCH v2] staging/lustre/libcfs: staging/lustre/libcfs: drop bogus Kconfig default Paul Bolle
2013-07-13 16:47 ` Paul Bolle
2013-07-13 17:26 ` Greg Kroah-Hartman
2013-07-13 18:46 ` [PATCH v3] " Paul Bolle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130713160716.GA2279@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pebolle@tiscali.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.