From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: request_region return value check
Date: Mon, 15 Jul 2013 13:20:26 +0000 [thread overview]
Message-ID: <20130715132026.GB5100@mwanda> (raw)
In-Reply-To: <20130714173056.GA50500@gmail.com>
On Sun, Jul 14, 2013 at 11:00:58PM +0530, Vivek Subbarao wrote:
> There are many places where the return value from request_region is not
> checked for null value. This is required right ? I am just checking
> before I can send patched fixing them
Most of the time, but not always.
Sometimes people know it will succeed. The first one I looked at
in drivers/acpi/acpi_processor.c the caller doesn't care if it
succeeds and there is a comment explaining why.
regards,
dan carpenter
next prev parent reply other threads:[~2013-07-15 13:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-14 17:42 request_region return value check Vivek Subbarao
2013-07-15 13:20 ` Dan Carpenter [this message]
2013-07-15 17:17 ` Vivek Subbarao
2013-07-15 20:06 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130715132026.GB5100@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.