From: "Daniel Glöckner" <dg@emlix.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH 08/10] ASoC: s6000: Fix unlocked snd_pcm_stop() call
Date: Mon, 15 Jul 2013 18:02:48 +0200 [thread overview]
Message-ID: <20130715160247.GA13522@emlix.com> (raw)
In-Reply-To: <1373893582-17116-9-git-send-email-tiwai@suse.de>
Nack
On Mon, Jul 15, 2013 at 03:06:20PM +0200, Takashi Iwai wrote:
> --- a/sound/soc/s6000/s6000-pcm.c
> +++ b/sound/soc/s6000/s6000-pcm.c
> @@ -128,7 +128,9 @@ static irqreturn_t s6000_pcm_irq(int irq, void *data)
> substream->runtime &&
> snd_pcm_running(substream)) {
> dev_dbg(pcm->dev, "xrun\n");
> + snd_pcm_stream_lock(substream);
> snd_pcm_stop(substream, SNDRV_PCM_STATE_XRUN);
> + snd_pcm_substream_unlock(substream);
I think this is supposed to be a call to snd_pcm_stream_unlock.
Daniel
--
Dipl.-Math. Daniel Glöckner, emlix GmbH, http://www.emlix.com
Fon +49 551 30664-0, Fax +49 551 30664-11,
Bertha-von-Suttner-Straße 9, 37085 Göttingen, Germany
Sitz der Gesellschaft: Göttingen, Amtsgericht Göttingen HR B 3160
Geschäftsführung: Dr. Uwe Kracke, Ust-IdNr.: DE 205 198 055
emlix - your embedded linux partner
next prev parent reply other threads:[~2013-07-15 16:02 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-15 13:06 [PATCH 0/10] snd_pcm_stop() lock fixes Takashi Iwai
2013-07-15 13:06 ` [PATCH 01/10] ALSA: asihpi: Fix unlocked snd_pcm_stop() call Takashi Iwai
2013-07-15 13:06 ` [PATCH 02/10] ALSA: atiixp: " Takashi Iwai
2013-07-15 13:06 ` [PATCH 03/10] ALSA: 6fire: " Takashi Iwai
2013-07-15 13:06 ` [PATCH 04/10] ALSA: ua101: " Takashi Iwai
2013-07-15 19:01 ` Clemens Ladisch
2013-07-15 13:06 ` [PATCH 05/10] ALSA: usx2y: " Takashi Iwai
2013-07-15 13:06 ` [PATCH 06/10] ALSA: pxa2xx: " Takashi Iwai
2013-07-15 16:00 ` Mark Brown
2013-07-15 13:06 ` [PATCH 07/10] ASoC: atmel: " Takashi Iwai
2013-07-15 16:00 ` Mark Brown
2013-07-15 13:06 ` [PATCH 08/10] ASoC: s6000: " Takashi Iwai
2013-07-15 16:00 ` Mark Brown
2013-07-15 16:02 ` Daniel Glöckner [this message]
2013-07-15 16:05 ` Takashi Iwai
2013-07-15 13:06 ` [PATCH 09/10] [media] saa7134: " Takashi Iwai
2013-07-15 13:06 ` [PATCH 10/10] staging: line6: " Takashi Iwai
2013-07-15 13:12 ` [PATCH 0/10] snd_pcm_stop() lock fixes Jaroslav Kysela
2013-07-15 13:17 ` Takashi Iwai
2013-07-16 14:48 ` Takashi Iwai
2013-07-16 14:54 ` Lars-Peter Clausen
2013-07-16 15:10 ` Takashi Iwai
2013-07-16 15:57 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130715160247.GA13522@emlix.com \
--to=dg@emlix.com \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.