From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: grub-devel@gnu.org
Subject: [PATCH] remove dependency on /boot/config-* in grub.d/20_linux_xen
Date: Mon, 15 Jul 2013 14:00:06 -0400 [thread overview]
Message-ID: <20130715180006.GA2433@phenom.dumpdata.com> (raw)
Hey,
There is a discussion on the linux-kernel mailing list in which the
Linus states that "if you depend on any config file, you're broken
by definition" (https://lkml.org/lkml/2013/7/15/368).
The 20_linux_xen does that however it should not do it. In all fairness
this check is a bit of old as pretty much any upstream kernel
is being built by default from distros to boot with Xen. If it does
not, Xen will print a message telling the user that Linux does not
have the required components.
This patch removes said check.
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
=== modified file 'util/grub.d/20_linux_xen.in'
--- util/grub.d/20_linux_xen.in 2013-03-24 13:03:33 +0000
+++ util/grub.d/20_linux_xen.in 2013-07-15 17:34:32 +0000
@@ -144,20 +144,8 @@
}
linux_list=`for i in /boot/vmlinu[xz]-* /vmlinu[xz]-* /boot/kernel-*; do
- if grub_file_is_not_garbage "$i"; then
- basename=$(basename $i)
- version=$(echo $basename | sed -e "s,^[^0-9]*-,,g")
- dirname=$(dirname $i)
- config=
- for j in "${dirname}/config-${version}" "${dirname}/config-${alt_version}" "/etc/kernels/kernel-config-${version}" ; do
- if test -e "${j}" ; then
- config="${j}"
- break
- fi
- done
- if (grep -qx "CONFIG_XEN_DOM0=y" "${config}" 2> /dev/null || grep -qx "CONFIG_XEN_PRIVILEGED_GUEST=y" "${config}" 2> /dev/null); then echo -n "$i " ; fi
- fi
- done`
+ if grub_file_is_not_garbage "$i"; then echo -n "$i "; fi
+ done`
if [ "x${linux_list}" = "x" ] ; then
exit 0
fi
next reply other threads:[~2013-07-15 18:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-15 18:00 Konrad Rzeszutek Wilk [this message]
2013-07-25 21:24 ` [PATCH] remove dependency on /boot/config-* in grub.d/20_linux_xen Vladimir 'φ-coder/phcoder' Serbinenko
2013-07-26 18:50 ` konrad wilk
2013-07-26 19:02 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-07-29 14:52 ` Konrad Rzeszutek Wilk
2013-07-29 16:52 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-11-10 20:40 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-11-11 13:51 ` Konrad Rzeszutek Wilk
2013-11-13 13:56 ` Konrad Rzeszutek Wilk
2013-11-13 13:56 ` Konrad Rzeszutek Wilk
2013-11-14 11:50 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-11-14 11:50 ` Vladimir 'φ-coder/phcoder' Serbinenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130715180006.GA2433@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.