All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Cc: Jeff King <peff@peff.net>, Junio C Hamano <gitster@pobox.com>,
	GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [RFC/PATCH] Add the NO_SENTINEL build variable
Date: Mon, 15 Jul 2013 11:13:57 -0700	[thread overview]
Message-ID: <20130715181357.GF14690@google.com> (raw)
In-Reply-To: <51E4338E.4090003@ramsay1.demon.co.uk>

Ramsay Jones wrote:

> One of the three gcc compilers that I use does not understand the
> sentinel function attribute. (so, it spews 108 warning messages)

Do you know what version of gcc introduced the sentinel attribute?
Would it make sense for the ifdef in git-compat-util.h to be keyed on 
__GNUC__ and __GNUC_MINOR__ instead of a new makefile flag?

Thanks,
Jonathan

  reply	other threads:[~2013-07-15 18:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-15 17:38 [RFC/PATCH] Add the NO_SENTINEL build variable Ramsay Jones
2013-07-15 18:13 ` Jonathan Nieder [this message]
2013-07-18 17:27   ` Ramsay Jones
2013-07-18 21:25     ` Junio C Hamano
2013-07-20 17:51       ` Ramsay Jones
2013-07-17 16:06 ` Junio C Hamano
2013-07-17 16:55   ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130715181357.GF14690@google.com \
    --to=jrnieder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    --cc=ramsay@ramsay1.demon.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.